Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.11] Bug 2106723: Remove rollback deployment #3249

Merged
merged 2 commits into from
Jul 13, 2022
Merged

[release-4.11] Bug 2106723: Remove rollback deployment #3249

merged 2 commits into from
Jul 13, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #3243

/assign sinnykumari

jmarrero and others added 2 commits July 13, 2022 11:34
@jmarrero
Bug 2104619: Remove rollback deployment openshift#3243
f9930f9 
This reverts commit 25a7812.
to provide a fix to:
https://bugzilla.redhat.com/show_bug.cgi?id=2104619
@cheesesashimi
remove redundant kargs assertions
dd3c568 
The Config Drift Monitor has no interaction with kernel args. This
particular case is better covered by the TestKernelArguments test.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 13, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2022

@openshift-cherrypick-robot: Bugzilla bug 2104619 has been cloned as Bugzilla bug 2106723. Retitling PR to link against new bug.
/retitle [release-4.11] Bug 2106723: Remove rollback deployment

In response to this:

[release-4.11] Bug 2104619: Remove rollback deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.11] Bug 2104619: Remove rollback deployment [release-4.11] Bug 2106723: Remove rollback deployment Jul 13, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2106723, which is invalid:

  • expected dependent Bugzilla bug 2104619 to target a release in 4.12.0, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.11] Bug 2106723: Remove rollback deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from cheesesashimi and jkyros July 13, 2022 11:35
@travier
Copy link
Member

travier commented Jul 13, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2022

@travier: This pull request references Bugzilla bug 2106723, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2104619 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2104619 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @djslavens

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from djslavens July 13, 2022 12:04
@sinnykumari
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 13, 2022
jmarrero
jmarrero approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sinnykumari
Copy link
Contributor

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmarrero, openshift-cherrypick-robot, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sinnykumari
Copy link
Contributor

Look like cleaning up rollback deployment might be taking some extra time which is causing gcp-op getting time out

@jmarrero
Copy link
Member

Look like cleaning up rollback deployment might be taking some extra time which is causing gcp-op getting time out

4.12 passed the test, is it taking time more too because of system load at this time?

@jmarrero
Copy link
Member

/test e2e-gcp-op

@mrunalp mrunalp added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jul 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2022

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive dd3c568 link false /test e2e-aws-disruptive
ci/prow/e2e-aws-upgrade-single-node dd3c568 link false /test e2e-aws-upgrade-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit e722bb7 into openshift:release-4.11 Jul 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2106723 has been moved to the MODIFIED state.

In response to this:

[release-4.11] Bug 2106723: Remove rollback deployment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarrero jmarrero jmarrero approved these changes

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@jkyros jkyros Awaiting requested review from jkyros

@djslavens djslavens Awaiting requested review from djslavens

Assignees

@sinnykumari sinnykumari

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @travier @sinnykumari @jmarrero @mrunalp @cheesesashimi