MCO-565: MCO-568: Create initial stub for Machine OS Builder binary, Initial Opt-in Mechanism #3652

dkhater-redhat · 2023-03-31T15:42:55Z

- What I did
added machine-os-builder binaries, manifests, and edited makefile to include machine-os builder. wrote simple "hello world" function for main.go

- How to verify it

- Description for the changelog

openshift-ci-robot · 2023-04-03T14:45:48Z

@dkhater-redhat: This pull request references MCO-563 which is a valid jira issue.

In response to this:

- What I did
added machine-os-builder binaries, manifests, and edited makefile to include machine-os builder. wrote simple "hello world" function for main.go

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2023-04-03T14:55:53Z

@dkhater-redhat: This pull request references MCO-565 which is a valid jira issue.

In response to this:

- What I did
added machine-os-builder binaries, manifests, and edited makefile to include machine-os builder. wrote simple "hello world" function for main.go

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

manifests/machineosbuilder/deployment.yaml

manifests/machineosbuilder/clusterrole.yaml

…ler with label

…ool / node

…e added

Co-authored-by: John Kyros <[email protected]>

…moved newEmpty variable

cheesesashimi · 2023-06-27T18:16:46Z

/test unit
/test e2e-aws-ovn
/test verify

dkhater-redhat · 2023-06-27T18:51:35Z

/test unit
/test e2e-aws-ovn
/test verify

cheesesashimi · 2023-06-27T20:44:30Z

hack/build-in-cluster.py

@@ -0,0 +1,355 @@
+#!/usr/bin/env python3


Lets drop this file from this PR, just to keep things well-scoped.

hack/cluster-push.sh

cheesesashimi

Overall this looks great! I think some of your other work may have been accidentally integrated into this PR, so lets try to carve that out and squash your commits as well.

pkg/controller/node/node_controller.go

cheesesashimi · 2023-06-27T20:55:00Z

pkg/daemon/daemon.go

@@ -1617,7 +1617,7 @@ func (dn *Daemon) updateSSHKeyLocation(cfg *mcfgv1.MachineConfig) error {
 		return fmt.Errorf("ignition failure when updating SSH key location: %w", err)
 	}

-	if err := dn.updateSSHKeys(ignConfig.Passwd.Users); err != nil {
+	if err := dn.updateSSHKeys(ignConfig.Passwd.Users, ignConfig.Passwd.Users); err != nil {


Is this somehow leftover from your work around SSH? It seems out of place for this PR.

openshift-ci · 2023-06-27T20:58:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dkhater-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Removed ssh bug, tidied up code, added labels, removed glog

openshift-merge-robot · 2023-06-28T10:11:15Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2023-07-03T12:52:16Z

@dkhater-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-alibabacloud-ovn	6f9e3acfe67a6315f346cfd71dc04bb4568aae4f	link	false	`/test e2e-alibabacloud-ovn`
ci/prow/okd-scos-e2e-gcp-ovn-upgrade	6f9e3acfe67a6315f346cfd71dc04bb4568aae4f	link	false	`/test okd-scos-e2e-gcp-ovn-upgrade`
ci/prow/verify	59a56d7e3667bc90db04584104f77325828eeb44	link	true	`/test verify`
ci/prow/e2e-aws-ovn	59a56d7e3667bc90db04584104f77325828eeb44	link	true	`/test e2e-aws-ovn`
ci/prow/e2e-hypershift	`aa71b7f`	link	true	`/test e2e-hypershift`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci bot requested review from sinnykumari and yuqi-zhang March 31, 2023 15:46

dkhater-redhat changed the title ~~added binaries, manifests, and edited makefile~~ MCO-563: Create initial internal-only Machine OS Builder API Apr 3, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2023

dkhater-redhat changed the title ~~MCO-563: Create initial internal-only Machine OS Builder API~~ MCO-565: Create initial stub for Machine OS Builder binary Apr 3, 2023

cheesesashimi reviewed Apr 6, 2023

View reviewed changes

manifests/machineosbuilder/deployment.yaml Outdated Show resolved Hide resolved

cheesesashimi reviewed Apr 6, 2023

View reviewed changes

manifests/machineosbuilder/clusterrole.yaml Show resolved Hide resolved

dkhater-redhat changed the title ~~MCO-565: Create initial stub for Machine OS Builder binary~~ MCO-565: MCO-568: Create initial stub for Machine OS Builder binary, Initial Opt-in Mechanism May 3, 2023

dkhater-redhat and others added 18 commits June 6, 2023 17:23

added binaries, manifests, and edited makefile

1ac077d

Rename deployment.yaml to eployment.yaml.to-be-implemented

3145baf

ignores deployment.yaml

ea1b01a

fixed misnamed component name

b0b7426

unignored deployment.yaml, added it to manifests

0fecb02

populated deployment.yaml simple

40617c8

added sync function for mob

d6dda88

added items around images, builds, and ImageStreams

1b91773

added image to deployment.yaml, got manifest to work

6b83ad5

changed hack cluster push

59d65dc

added namespace, additional configuration for mob

1f53493

modified hack cluster script

8038b75

added code to look at pools, comments

a69e82f

testing by removing comment

cd131fd

added newlines

53aa55d

seeing why on-cluster-build label isnt showing up

4dc1a63

trying separating function

bf492ec

oc line issues

0297f17

dkhater-redhat force-pushed the mco-565 branch from e13f97f to 0297f17 Compare June 6, 2023 22:24

seeing if pools will get output

9ec92c6

dkhater-redhat and others added 15 commits June 8, 2023 13:26

added node controller opt in functionality. should pause node control…

98119dd

…ler with label

Deleting SSH keys / password hashes should not degrade MachineConfigP…

af2649d

…ool / node

removed unit test to verify that another user that isnt core cannot b…

92bbc23

…e added

wrongfully removed test case

fc13544

removed unit test for causing panic if users is empty

5fcf0e8

Update pkg/daemon/update.go

5227b03

Co-authored-by: John Kyros <[email protected]>

added back test to ensure that the empty users is reconcilable and re…

3811816

…moved newEmpty variable

oops space

7930146

added functionality to clear out password when core user is removed

b81edf3

making so that updateSSHKeys runs in all cases

3800dea

removed on cluster build key

63d53a5

testing functionality of pausing node controller

d40072a

added comments for clarity

8bb59fb

seeing if node controller sees new mcp

0bc705f

rework Machine OS Builder startup logic

556d5e9

cheesesashimi reviewed Jun 27, 2023

View reviewed changes

hack/cluster-push.sh Outdated Show resolved Hide resolved

cheesesashimi suggested changes Jun 27, 2023

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023

dkhater-redhat force-pushed the mco-565 branch 2 times, most recently from 68c7a1c to c3a76f9 Compare June 28, 2023 09:48

Move all log functions to klog

aa71b7f

Removed ssh bug, tidied up code, added labels, removed glog

dkhater-redhat force-pushed the mco-565 branch from c3a76f9 to aa71b7f Compare June 28, 2023 10:11

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2023

dkhater-redhat closed this Jul 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MCO-565: MCO-568: Create initial stub for Machine OS Builder binary, Initial Opt-in Mechanism #3652

MCO-565: MCO-568: Create initial stub for Machine OS Builder binary, Initial Opt-in Mechanism #3652

dkhater-redhat commented Mar 31, 2023

openshift-ci-robot commented Apr 3, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 3, 2023 •

edited by openshift-ci bot

Loading

cheesesashimi commented Jun 27, 2023

dkhater-redhat commented Jun 27, 2023

cheesesashimi Jun 27, 2023

cheesesashimi left a comment •

edited

Loading

cheesesashimi Jun 27, 2023

openshift-ci bot commented Jun 27, 2023

openshift-merge-robot commented Jun 28, 2023

openshift-ci bot commented Jul 3, 2023

MCO-565: MCO-568: Create initial stub for Machine OS Builder binary, Initial Opt-in Mechanism #3652

MCO-565: MCO-568: Create initial stub for Machine OS Builder binary, Initial Opt-in Mechanism #3652

Conversation

dkhater-redhat commented Mar 31, 2023

openshift-ci-robot commented Apr 3, 2023 • edited by openshift-ci bot Loading

openshift-ci-robot commented Apr 3, 2023 • edited by openshift-ci bot Loading

cheesesashimi commented Jun 27, 2023

dkhater-redhat commented Jun 27, 2023

cheesesashimi Jun 27, 2023

Choose a reason for hiding this comment

cheesesashimi left a comment • edited Loading

Choose a reason for hiding this comment

cheesesashimi Jun 27, 2023

Choose a reason for hiding this comment

openshift-ci bot commented Jun 27, 2023

openshift-merge-robot commented Jun 28, 2023

openshift-ci bot commented Jul 3, 2023

openshift-ci-robot commented Apr 3, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 3, 2023 •

edited by openshift-ci bot

Loading

cheesesashimi left a comment •

edited

Loading