MCO-585: Introduce BuildController #3665
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@cheesesashimi: This pull request references MCO-585 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheesesashimi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test verify |
cheesesashimi
force-pushed
the
zzlotnik/land-buildcontroller
branch
from
b8931db to
dc2c7de
Compare
|
@cheesesashimi: This pull request references MCO-585 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cheesesashimi
force-pushed
the
zzlotnik/land-buildcontroller
branch
2 times, most recently
from
a9ac1ea to
a256977
Compare
We need to specify what resources the pool should be creating/owning in order to manage builds and the relationships between them (triggers, which buildconfigs should source from which streams, etc). The pool needs some template/plan to follow when it gets triggered to create and verify that its resources exist. This is my not-quite-as-elegant-as-I-had-hoped attempt at that.
The build controller "takes over" for pools that are marked as layered. It will more or less serve the function of the render controller but for image based pools. The render controller currently retains the functionality of generating the rendered config, and will push that rendered config into an imagestream every time it gets updated.
This adds helpers for getting and setting the current image stream for a pool, separates the per-pool suffix '-base' from the global 'coreos' imagestream, and adds a per-node stream name constant for later.
I don't know that we'll ultimately end up with imagestreams with these names but for right now, I think these are at least the ones we think we want that have purposes behind them.
cheesesashimi
force-pushed
the
zzlotnik/land-buildcontroller
branch
from
a256977 to
4c85d9b
Compare
cheesesashimi
force-pushed
the
zzlotnik/land-buildcontroller
branch
from
4c85d9b to
1d33445
Compare
|
/test test-unit |
|
/test unit |
|
@cheesesashimi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This is replaced by #3731 |
- What I did
This cherry-picks some of the BuildController commits from the layering branch into master and implements a fairly simple state machine as a first-pass.
- How to verify it
For now, this code is not active, however its unit tests will be run as part of CI.
- Description for the changelog
Introduces BuildController