-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Add AUTHFILE option to make image #4741
base: master
Are you sure you want to change the base?
Conversation
When building the mco image, add an AUTHFILE check to allow users to specify a different file from the default one for the authentication to be used during the build process. Signed-off-by: Urvashi <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@umohnani8: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@umohnani8: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
When building the mco image, add an AUTHFILE check to allow users to specify a different file from the default one for the authentication to be used during the build process.
This is something I kept having to change manually because I use a different location for my openshift auth and not the default one that podman looks at.
- What I did
Add AUTHFILE option to make image to allow specifying a file path for the auth needed during build
- How to verify it
run make image AUTHFILE=path/to/auth file and the podman build command outputed should have
--authfile=path/you/specified
- Description for the changelog
Add AUTHFILE option to make image to allow specifying a file path for the auth needed during build