Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-19337: enable injection of custom kubelet labels via env var for master nodes #4746

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rccrdpccl
Copy link

- What I did
added CUSTOM_KUBELET_LABELS env var to --node-labels parameter for kubelet in master node's template
The use case is a CAPI bootstrap provider install openshift need to advertise a given provider ID via label, so that the infrastructure provider can set the actual provider ID once verified.

- How to verify it
add CUSTOM_KUBELET_LABELS=mydummylabel=myvalue to any of the environmental files used by kubelet (possibly /etc/kubernetes/kubelet-envs)

- Description for the changelog

Inject master node labels via CUSTOM_KUBELET_LABELS env var

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 11, 2024

@rccrdpccl: This pull request references MGMT-19337 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did
added CUSTOM_KUBELET_LABELS env var to --node-labels parameter for kubelet in master node's template
The use case is a CAPI bootstrap provider install openshift need to advertise a given provider ID via label, so that the infrastructure provider can set the actual provider ID once verified.

- How to verify it
add CUSTOM_KUBELET_LABELS=mydummylabel=myvalue to any of the environmental files used by kubelet (possibly /etc/kubernetes/kubelet-envs)

- Description for the changelog

Inject master node labels via CUSTOM_KUBELET_LABELS env var

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 11, 2024
Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rccrdpccl
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rccrdpccl
Copy link
Author

/retest

1 similar comment
@rccrdpccl
Copy link
Author

/retest

@rccrdpccl
Copy link
Author

@umohnani8 could you please take a look 🙏 ?

@rccrdpccl
Copy link
Author

/retest

2 similar comments
@rccrdpccl
Copy link
Author

/retest

@rccrdpccl
Copy link
Author

/retest

Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

@rccrdpccl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 38b0447 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants