-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-19337: enable injection of custom kubelet labels via env var for master nodes #4746
base: master
Are you sure you want to change the base?
Conversation
… master nodes Signed-off-by: Riccardo Piccoli <[email protected]>
@rccrdpccl: This pull request references MGMT-19337 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rccrdpccl The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
@umohnani8 could you please take a look 🙏 ? |
/retest |
2 similar comments
/retest |
/retest |
@rccrdpccl: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- What I did
added CUSTOM_KUBELET_LABELS env var to --node-labels parameter for kubelet in master node's template
The use case is a CAPI bootstrap provider install openshift need to advertise a given provider ID via label, so that the infrastructure provider can set the actual provider ID once verified.
- How to verify it
add
CUSTOM_KUBELET_LABELS=mydummylabel=myvalue
to any of the environmental files used by kubelet (possibly/etc/kubernetes/kubelet-envs
)- Description for the changelog
Inject master node labels via CUSTOM_KUBELET_LABELS env var