-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync OWNERS_ALIASES with boilerplate #2290
base: master
Are you sure you want to change the base?
Conversation
/label tide/merge-method-squash |
Thanks Anthony for the PR and the detailed description. Ran yamldiff with
Which should be expected as MCC-specific group aliases. Just one nit, looks |
@abyrne55: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: abyrne55, iamkirkbater, xiaoyu74 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This cleanup PR updates OWNERS_ALIASES to look more like that of openshift/boilerplate, specifically this file. This is not a perfect 1:1 sync to boilerplate because I wanted to preserve the MCC-specific group aliases (region leads,
sre-alert-sme
, andsre-mst-observatorium
).Most of the changes are just group membership updates reflecting the past year of re-orgs and turnover. Boilerplate also renamed the
sd-architects
group tosrep-architects
, so this PR mirrors that change and patches the 1 file in this repo that used that group alias. We also addsrep-architects
to the root-level approvers and reviewers, as the architects are no longer captured in the team-leads group.Note that the boilerplate version was ordered differently than this repo's, so the diff looks a lot more dramatic than it actually is (feel free to use yamldiff to verify).