Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync OWNERS_ALIASES with boilerplate #2290

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

abyrne55
Copy link
Contributor

@abyrne55 abyrne55 commented Dec 4, 2024

This cleanup PR updates OWNERS_ALIASES to look more like that of openshift/boilerplate, specifically this file. This is not a perfect 1:1 sync to boilerplate because I wanted to preserve the MCC-specific group aliases (region leads, sre-alert-sme, and sre-mst-observatorium).

Most of the changes are just group membership updates reflecting the past year of re-orgs and turnover. Boilerplate also renamed the sd-architects group to srep-architects, so this PR mirrors that change and patches the 1 file in this repo that used that group alias. We also add srep-architects to the root-level approvers and reviewers, as the architects are no longer captured in the team-leads group.

Note that the boilerplate version was ordered differently than this repo's, so the diff looks a lot more dramatic than it actually is (feel free to use yamldiff to verify).

@abyrne55
Copy link
Contributor Author

abyrne55 commented Dec 4, 2024

/label tide/merge-method-squash
/kind cleanup

@openshift-ci openshift-ci bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Dec 4, 2024
@jewzaam jewzaam removed their request for review December 4, 2024 20:14
@xiaoyu74
Copy link
Contributor

xiaoyu74 commented Dec 4, 2024

Thanks Anthony for the PR and the detailed description. Ran yamldiff with boilerplate and only shows the 3 sections difference:

  • sre-alert-sme:
  • sre-mst-observatorium:
  • srep-region-leads

Which should be expected as MCC-specific group aliases.

Just one nit, looks srep-region-leads list is not updated, @devppratik has taken over @MitaliBhalla for APAC West OSD/ROSA.

Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

@abyrne55: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xiaoyu74
Copy link
Contributor

xiaoyu74 commented Dec 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@iamkirkbater
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abyrne55, iamkirkbater, xiaoyu74
Once this PR has been reviewed and has the lgtm label, please assign cblecker for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants