Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCM-12870] define management cluster cronjob to perform olm dance #2294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cdoan1
Copy link
Contributor

@cdoan1 cdoan1 commented Dec 6, 2024

What type of PR is this?

cleanup

What this PR does / why we need it?

When fleet manager enables the upgrade of OADP 1.2 -> OADP 1.3, OLM may get stuck.
introduce a new cronjob to do OLM dance.

Which Jira/Github issue(s) this PR fixes?

OCM-12870

Special notes for your reviewer:

Pre-checks (if applicable):

  • Tested latest changes against a cluster

  • Included documentation changes with PR

  • If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

    matchExpressions:
    - key: api.openshift.com/fedramp
      operator: NotIn
      values: ["true"]

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2024
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cdoan1 cdoan1 force-pushed the OCM-12870-create-mcc-cronjob-oadp-operator-dance branch from 0133dbc to 0300628 Compare December 6, 2024 22:50
@cdoan1 cdoan1 marked this pull request as ready for review December 9, 2024 16:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2024
@cdoan1
Copy link
Contributor Author

cdoan1 commented Dec 9, 2024

This MR may need to wait for FM promotion

@openshift-ci openshift-ci bot requested review from fahlmant and tnierman December 9, 2024 16:18
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

@cdoan1: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bergmannf
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2024
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bergmannf, cdoan1
Once this PR has been reviewed and has the lgtm label, please assign iamkirkbater for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants