Skip to content

Commit

Permalink
Add 'name' parameter for OCM cluster search
Browse files Browse the repository at this point in the history
Some clusters use "display_name" as a longer, more descriptive field.
And example of this is `osd-v4stg-aws`, which has:

```
Display Name:	SRE long lived cluster in production: osd-v4stg-aws
```

This causes osd-v4stg-aws (or others) to not be found when searching by the human
friendly name, as identified by @rendhalver in a [recent pr
review](#300 (comment)).

This PR adds "name" to the OCM cluster search parameters, which is the
parameter used by ocm-cli when it performs the same search.

Signed-off-by: Chris Collins <[email protected]>
  • Loading branch information
clcollins committed Aug 14, 2024
1 parent 2d9e91d commit 05a01eb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion utils/bashrc.d/06-sre-login-libs.bashrc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# shellcheck shell=bash

function cluster_info_env_export(){
SEARCH_STRING="id like '$INITIAL_CLUSTER_LOGIN' or external_id like '$INITIAL_CLUSTER_LOGIN' or display_name like '$INITIAL_CLUSTER_LOGIN'"
SEARCH_STRING="id like '$INITIAL_CLUSTER_LOGIN' or external_id like '$INITIAL_CLUSTER_LOGIN' or name like '$INITIAL_CLUSTER_LOGIN' or display_name like '$INITIAL_CLUSTER_LOGIN'"
cluster_details=$(ocm list clusters --parameter=search="(($SEARCH_STRING))" --columns "id, external_id, name" --no-headers)
CLUSTER_ID=$(awk '{print $1}' <<< $cluster_details)
CLUSTER_UUID=$(awk '{print $2}' <<< $cluster_details)
Expand Down

0 comments on commit 05a01eb

Please sign in to comment.