Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

denylist: drop ext.config.shared.kdump.crash and coreos.boot-mirror tests #1364

Merged
merged 2 commits into from
Sep 15, 2023
Merged

denylist: drop ext.config.shared.kdump.crash and coreos.boot-mirror tests #1364

merged 2 commits into from
Sep 15, 2023

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Sep 13, 2023

denylist: drop ext.config.shared.kdump.crash

This was fixed at some point in the last 1.5 years, likely when we moved
to RHEL9.

denylist: drop coreos.boot-mirror tests

These should now be fixed by
coreos/coreos-assembler#3611.

@jlebon
denylist: drop ext.config.shared.kdump.crash
e16e6e2 
This was fixed at some point in the last 1.5 years, likely when we moved
to RHEL9.
@jlebon
denylist: drop coreos.boot-mirror tests
8b66876 
These should now be fixed by
coreos/coreos-assembler#3611.
@jlebon jlebon marked this pull request as draft September 13, 2023 20:42
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2023
@jlebon
Copy link
Member Author

jlebon commented Sep 13, 2023

Requires: coreos/coreos-assembler#3611

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@jlebon jlebon marked this pull request as ready for review September 14, 2023 20:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2023
@jlebon
Copy link
Member Author

jlebon commented Sep 14, 2023

This is ready now!

@openshift-ci openshift-ci bot requested review from c4rt0 and dustymabe September 14, 2023 20:28
dustymabe
dustymabe approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2023
@dustymabe dustymabe removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 14, 2023
@dustymabe
Copy link
Member

Dropping my approval for now while we investigate an issue: coreos/fedora-coreos-config#2597 (comment)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 14, 2023

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dustymabe
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0494b05 into openshift:master Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustymabe dustymabe dustymabe approved these changes

@travier travier Awaiting requested review from travier

@yasminvalim yasminvalim Awaiting requested review from yasminvalim

@c4rt0 c4rt0 Awaiting requested review from c4rt0

Assignees

@dustymabe dustymabe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlebon @dustymabe @openshift-merge-robot