Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: tests/kola/version/rhel-major-version: adapt for pure RHEL variants #1531

Merged

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Jun 18, 2024

This probably should've been part of 4e09d27 ("Make c9s and rhel-9.4 variants be pure C9S/RHEL 9.4 content"), which edited that same test for the for pure CentOS Stream variant.

This probably should've been part of 4e09d27 ("Make c9s and rhel-9.4
variants be pure C9S/RHEL 9.4 content"), which edited that same test for
the for pure CentOS Stream variant.
@openshift-ci openshift-ci bot requested review from aaradhak and c4rt0 June 18, 2024 21:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
Copy link
Contributor

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmarrero
Copy link
Member

/retest-required

@jlebon
Copy link
Member Author

jlebon commented Jun 19, 2024

This is going to keep failing on #1523. But ext.config.version.rhel-major-version passed in both, which is the only test changed here. So:

/override ci/prow/rhcos-9-build-test-qemu
/override ci/prow/scos-9-build-test-qemu

That said, this still needs an actual /lgtm.

Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos-9-build-test-qemu, ci/prow/scos-9-build-test-qemu

In response to this:

This is going to keep failing on #1523. But ext.config.version.rhel-major-version passed in both, which is the only test changed here. So:

/override ci/prow/rhcos-9-build-test-qemu
/override ci/prow/scos-9-build-test-qemu

That said, this still needs an actual /lgtm.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@travier
Copy link
Member

travier commented Jun 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2024
Copy link
Contributor

openshift-ci bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, marmijo, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jlebon,marmijo,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon jlebon changed the title tests/kola/version/rhel-major-version: adapt for pure RHEL variants NO-JIRA: tests/kola/version/rhel-major-version: adapt for pure RHEL variants Jun 19, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 19, 2024
@openshift-ci-robot
Copy link

@jlebon: This pull request explicitly references no jira issue.

In response to this:

This probably should've been part of 4e09d27 ("Make c9s and rhel-9.4 variants be pure C9S/RHEL 9.4 content"), which edited that same test for the for pure CentOS Stream variant.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f86271b into openshift:master Jun 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants