Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.16] OCPBUGS-36147: Bump fedora-coreos-config #1538

Conversation

coreosbot-releng
Copy link

Created by GitHub workflow (source).

Jonathan Lebon (2):
      growfs: set PKNAME and partnum in multipath path
      growfs: workaround sfdisk + LUKS incompatibility on 512e disks

Jonathan Lebon (2):
      growfs: set PKNAME and partnum in multipath path
      growfs: workaround sfdisk + LUKS incompatibility on 512e disks
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 25, 2024
@openshift-ci-robot
Copy link

@coreosbot-releng: This pull request references Jira Issue OCPBUGS-35410, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.17.0" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-35410 to depend on a bug targeting a version in 4.17.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Created by GitHub workflow (source).

Jonathan Lebon (2):
     growfs: set PKNAME and partnum in multipath path
     growfs: workaround sfdisk + LUKS incompatibility on 512e disks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from marmijo and mike-nguyen June 25, 2024 06:58
@travier
Copy link
Member

travier commented Jun 25, 2024

/lgtm
/label backport-risk-assessed
/label cherry-pick-approved

@travier
Copy link
Member

travier commented Jun 25, 2024

/retest

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jun 25, 2024
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 25, 2024
@travier
Copy link
Member

travier commented Jun 25, 2024

/retitle OCPBUGS-36147: Bump fedora-coreos-config

@openshift-ci openshift-ci bot changed the title [release-4.16] OCPBUGS-35410: Bump fedora-coreos-config OCPBUGS-36147: Bump fedora-coreos-config Jun 25, 2024
@openshift-ci-robot
Copy link

@coreosbot-releng: This pull request references Jira Issue OCPBUGS-36147, which is invalid:

  • expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.17.0" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-36147 to depend on a bug targeting a version in 4.17.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Created by GitHub workflow (source).

Jonathan Lebon (2):
     growfs: set PKNAME and partnum in multipath path
     growfs: workaround sfdisk + LUKS incompatibility on 512e disks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@travier
Copy link
Member

travier commented Jun 25, 2024

/retitle [release-4.16] OCPBUGS-36147: Bump fedora-coreos-config

@openshift-ci openshift-ci bot changed the title OCPBUGS-36147: Bump fedora-coreos-config [release-4.16] OCPBUGS-36147: Bump fedora-coreos-config Jun 25, 2024
@travier
Copy link
Member

travier commented Jun 25, 2024

/jira refresh

@openshift-ci-robot
Copy link

@travier: This pull request references Jira Issue OCPBUGS-36147, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-36147 to depend on a bug targeting a version in 4.17.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@travier
Copy link
Member

travier commented Jun 25, 2024

/jira refresh

@openshift-ci-robot
Copy link

@travier: This pull request references Jira Issue OCPBUGS-36147, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-35410 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@travier
Copy link
Member

travier commented Jun 25, 2024

Error: Parsing metadata from src/config/tests/kola/shared/root-reprovision/luks/512e/test.sh: yaml: unmarshal errors:
  line 25: field primaryDisk not found in type kola.externalTestMeta
2024-06-25T09:37:52Z cli: Parsing metadata from src/config/tests/kola/shared/root-reprovision/luks/512e/test.sh: yaml: unmarshal errors:
  line 25: field primaryDisk not found in type kola.externalTestMeta
failed to execute cmd-kola: exit status 1

Needs a backport of coreos/coreos-assembler#3822

@jlebon
Copy link
Member

jlebon commented Jun 25, 2024

/retest

@jlebon
Copy link
Member

jlebon commented Jun 25, 2024

/jira refresh

@openshift-ci-robot
Copy link

@jlebon: This pull request references Jira Issue OCPBUGS-36147, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jlebon
Copy link
Member

jlebon commented Jun 25, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 25, 2024
@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 25, 2024
@openshift-ci-robot
Copy link

@jlebon: This pull request references Jira Issue OCPBUGS-36147, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-35410 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-35410 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson
Copy link
Member

sdodson commented Jun 25, 2024

/label staff-eng-approved

@openshift-ci openshift-ci bot added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jun 25, 2024
@jlebon
Copy link
Member

jlebon commented Jun 25, 2024

/test images
/test rhcos-9-build-test-qemu

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4729d1f and 2 for PR HEAD 9c8420c in total

@jlebon
Copy link
Member

jlebon commented Jun 25, 2024

Hmm weird, still seems to be using a stale 4.16 cosa.

@travier
Copy link
Member

travier commented Jun 25, 2024

/test images

Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreosbot-releng, marmijo, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member

jlebon commented Jun 25, 2024

/retest

@jlebon
Copy link
Member

jlebon commented Jun 25, 2024

Logs for ci/prow/images shows

FROM image-registry.openshift-image-registry.svc:5000/ci-op-0yq7b11x/pipeline@sha256:45edfa461413c22e52c9094f7220250512c43d753a21bde72964661350ff097b

which matches

$ skopeo inspect --no-tags docker://quay.io/coreos-assembler/coreos-assembler:rhcos-4.16 | jq .Digest
"sha256:45edfa461413c22e52c9094f7220250512c43d753a21bde72964661350ff097b"

So rhcos-9-build-test-qemu should pass now.

I'm honestly confused by the mess in openshift/release related to the coreos-assembler image. There's references there and in the logs here that there's a :4.16 tag in the coreos/coreos-assembler imagestream, but I don't see that in either https://console.build02.ci.openshift.org/k8s/ns/coreos/imagestreams/coreos-assembler or https://console-openshift-console.apps.ci.l2s4.p1.openshiftapps.com/k8s/ns/coreos/imagestreams/coreos-assembler.

Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

@coreosbot-releng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c22f952 into openshift:release-4.16 Jun 25, 2024
5 checks passed
@openshift-ci-robot
Copy link

@coreosbot-releng: Jira Issue OCPBUGS-36147: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36147 has been moved to the MODIFIED state.

In response to this:

Created by GitHub workflow (source).

Jonathan Lebon (2):
     growfs: set PKNAME and partnum in multipath path
     growfs: workaround sfdisk + LUKS incompatibility on 512e disks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants