Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: common.yaml: disable composefs on all arches #1700

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Dec 16, 2024

There are issues currently on ppc64le and kernel-64k in el9 that break with composefs. So it's not sufficient to do an architecture check anyway. See: https://issues.redhat.com/browse/RHEL-31991.

But additionally, there are issues also to resolve when dealing with old bootimages. This should be fixed by turning on composefs image generation by default in libostree and downgrading to maybe here. See: #1678.

Once we fix the latter issue, we should be able to turn it on at least in the el10 variants, where the first issue doesn't exist. (Though technically, even the latter issue is "fixed" in el10 by virtue of new enough libostree in the bootimages, but it would still break to go from an el9 bootimage to el10, which we'll likely have to support.)

@openshift-ci openshift-ci bot requested review from aaradhak and c4rt0 December 16, 2024 18:20
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
There are issues currently on ppc64le and kernel-64k in el9 that break
with composefs. So it's not sufficient to do an architecture check
anyway. See: https://issues.redhat.com/browse/RHEL-31991.

But additionally, there are issues also to resolve when dealing with
old bootimages. This should be fixed by turning on composefs image
generation by default in libostree and downgrading to `maybe` here. See:
openshift#1678.

Once we fix the latter issue, we should be able to turn it on at least
in the el10 variants, where the first issue doesn't exist. (Though
technically, even the latter issue is "fixed" in el10 by virtue of new
enough libostree in the bootimages, but it would still break to go from
an el9 bootimage to el10, which we'll likely have to support.)
@jlebon jlebon force-pushed the pr/back-out-composefs branch from d9ae116 to 2a61323 Compare December 16, 2024 18:26
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
@jlebon
Copy link
Member Author

jlebon commented Dec 16, 2024

/retest-all

@jlebon
Copy link
Member Author

jlebon commented Dec 16, 2024

/retest

1 similar comment
@jlebon
Copy link
Member Author

jlebon commented Dec 17, 2024

/retest

@jlebon jlebon changed the title common.yaml: disable composefs on all arches NO-JIRA: common.yaml: disable composefs on all arches Dec 17, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 17, 2024
@openshift-ci-robot
Copy link

@jlebon: This pull request explicitly references no jira issue.

In response to this:

There are issues currently on ppc64le and kernel-64k in el9 that break with composefs. So it's not sufficient to do an architecture check anyway. See: https://issues.redhat.com/browse/RHEL-31991.

But additionally, there are issues also to resolve when dealing with old bootimages. This should be fixed by turning on composefs image generation by default in libostree and downgrading to maybe here. See: #1678.

Once we fix the latter issue, we should be able to turn it on at least in the el10 variants, where the first issue doesn't exist. (Though technically, even the latter issue is "fixed" in el10 by virtue of new enough libostree in the bootimages, but it would still break to go from an el9 bootimage to el10, which we'll likely have to support.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@c4rt0
Copy link
Contributor

c4rt0 commented Dec 17, 2024

/retest

Copy link
Contributor

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c4rt0, jlebon, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [c4rt0,jlebon,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@c4rt0
Copy link
Contributor

c4rt0 commented Dec 17, 2024

/retest

1 similar comment
@c4rt0
Copy link
Contributor

c4rt0 commented Dec 17, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 643d8e7 and 2 for PR HEAD 2a61323 in total

@jlebon
Copy link
Member Author

jlebon commented Dec 17, 2024

/retest

2 similar comments
@Prashanth684
Copy link
Contributor

/retest

@jlebon
Copy link
Member Author

jlebon commented Dec 17, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 643d8e7 and 2 for PR HEAD 2a61323 in total

@c4rt0
Copy link
Contributor

c4rt0 commented Dec 17, 2024

/retest-required

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants