-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-JIRA: common.yaml: disable composefs on all arches #1700
base: master
Are you sure you want to change the base?
Conversation
There are issues currently on ppc64le and kernel-64k in el9 that break with composefs. So it's not sufficient to do an architecture check anyway. See: https://issues.redhat.com/browse/RHEL-31991. But additionally, there are issues also to resolve when dealing with old bootimages. This should be fixed by turning on composefs image generation by default in libostree and downgrading to `maybe` here. See: openshift#1678. Once we fix the latter issue, we should be able to turn it on at least in the el10 variants, where the first issue doesn't exist. (Though technically, even the latter issue is "fixed" in el10 by virtue of new enough libostree in the bootimages, but it would still break to go from an el9 bootimage to el10, which we'll likely have to support.)
d9ae116
to
2a61323
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest-all |
/retest |
1 similar comment
/retest |
@jlebon: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: c4rt0, jlebon, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/retest |
2 similar comments
/retest |
/retest |
/retest-required |
@jlebon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There are issues currently on ppc64le and kernel-64k in el9 that break with composefs. So it's not sufficient to do an architecture check anyway. See: https://issues.redhat.com/browse/RHEL-31991.
But additionally, there are issues also to resolve when dealing with old bootimages. This should be fixed by turning on composefs image generation by default in libostree and downgrading to
maybe
here. See: #1678.Once we fix the latter issue, we should be able to turn it on at least in the el10 variants, where the first issue doesn't exist. (Though technically, even the latter issue is "fixed" in el10 by virtue of new enough libostree in the bootimages, but it would still break to go from an el9 bootimage to el10, which we'll likely have to support.)