Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP OKD: add optional platform tests to fcos branch of the installer #6976

Closed
wants to merge 1 commit into from
Closed

WIP OKD: add optional platform tests to fcos branch of the installer #6976

wants to merge 1 commit into from

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Feb 3, 2020 •
edited
Loading

This enables PR testing for optional platforms - azure, gcp, ovirt, openstack. The tests are optional and would run on request only. Although rehearsals fail it would be useful to have these enabled so that we could test platform-specific PRs

Status:

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 3, 2020
@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 3, 2020

/cc @smarterclayton

@vrutkovs vrutkovs changed the title OKD: add optional platform tests to fcos branch of the installer WIP: OKD: add optional platform tests to fcos branch of the installer Feb 3, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2020
@vrutkovs vrutkovs changed the title WIP: OKD: add optional platform tests to fcos branch of the installer OKD: add optional platform tests to fcos branch of the installer Feb 3, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2020
@LorbusChris
Copy link
Member

/retest

1 similar comment
@vrutkovs
Copy link
Member Author

vrutkovs commented Feb 3, 2020

/retest

@openshift-bot
Copy link
Contributor

/test prow-config-filenames

@jstuever
Copy link
Contributor

/uncc @jstuever

@openshift-ci-robot openshift-ci-robot removed the request for review from jstuever February 10, 2020 19:35
@vrutkovs
Copy link
Member Author

/retest

3 similar comments
@vrutkovs
Copy link
Member Author

/retest

@vrutkovs
Copy link
Member Author

/retest

@vrutkovs
Copy link
Member Author

/retest

@vrutkovs vrutkovs mentioned this pull request Mar 10, 2020
Closed
@vrutkovs vrutkovs force-pushed the okd-optional-tests branch 2 times, most recently from 0648eeb to 06dc9c7 Compare March 16, 2020 08:31
@vrutkovs vrutkovs changed the title OKD: add optional platform tests to fcos branch of the installer WIP OKD: add optional platform tests to fcos branch of the installer Mar 16, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2020
@vrutkovs vrutkovs mentioned this pull request Mar 16, 2020
Closed
@vrutkovs vrutkovs force-pushed the okd-optional-tests branch from 06dc9c7 to a8cd700 Compare March 16, 2020 16:16
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs force-pushed the okd-optional-tests branch 2 times, most recently from dbc2c90 to a5f3140 Compare July 20, 2020 09:18
@vrutkovs vrutkovs force-pushed the okd-optional-tests branch from a5f3140 to 15649dc Compare August 20, 2020 09:23
Gal-Zaidman
Gal-Zaidman reviewed Aug 24, 2020
View reviewed changes
ci-operator/jobs/openshift/installer/openshift-installer-fcos-presubmits.yaml
containers:
- args:
- --artifact-dir=$(ARTIFACTS)
- --give-pr-author-access-to-namespace=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing:

  • --image-import-pull-secret=/etc/pull-secret/.dockerconfigjson
  • --kubeconfig=/etc/apici/kubeconfig
  • --repo=installer

Gal-Zaidman
Gal-Zaidman reviewed Aug 24, 2020
View reviewed changes
ci-operator/jobs/openshift/installer/openshift-installer-fcos-presubmits.yaml
env:
- name: CLUSTER_TYPE
value: ovirt
- name: CONFIG_SPEC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why do we need it

Gal-Zaidman
Gal-Zaidman reviewed Aug 24, 2020
View reviewed changes
ci-operator/jobs/openshift/installer/openshift-installer-fcos-presubmits.yaml
requests:
cpu: 10m
volumeMounts:
- mountPath: /usr/local/e2e-ovirt-cluster-profile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing:

  • mountPath: /etc/apici
    name: apici-ci-operator-credentials
    readOnly: true
  • mountPath: /etc/pull-secret
    name: pull-secret
    readOnly: true

@vrutkovs
OKD: add optional platform tests to fcos branch of the installer
f1f519f 
This enables PR testing for optional platforms - azure, gcp, ovirt, openstack
@vrutkovs vrutkovs force-pushed the okd-optional-tests branch from 15649dc to f1f519f Compare August 24, 2020 08:43
@Gal-Zaidman
Copy link
Contributor

/test e2e-ovirt

@openshift-ci-robot
Copy link
Contributor

@Gal-Zaidman: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test promrules
  • /test app-ci-config-dry
  • /test build01-dry
  • /test build02-dry
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test config
  • /test core-dry
  • /test core-valid
  • /test correctly-sharded-config
  • /test generated-config
  • /test generated-dashboards
  • /test ordered-prow-config
  • /test owners
  • /test pj-rehearse
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test release-controller-config
  • /test services-dry
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test vsphere-dry
  • /test pylint

Use /test all to run the following jobs:

  • pull-ci-openshift-release-master-app-ci-config-dry
  • pull-ci-openshift-release-master-build01-dry
  • pull-ci-openshift-release-master-build02-dry
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-dry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-generated-dashboards
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-pj-rehearse
  • pull-ci-openshift-release-master-prow-config
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-master-services-dry
  • pull-ci-openshift-release-master-services-valid
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-master-vsphere-dry

In response to this:

/test e2e-ovirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vrutkovs
Copy link
Member Author

/test pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/installer/fcos/verify-vendor f1f519f link /test pj-rehearse
ci/rehearse/openshift/installer/fcos/e2e-azure f1f519f link /test pj-rehearse
ci/rehearse/openshift/installer/fcos/e2e-openstack f1f519f link /test pj-rehearse
ci/rehearse/openshift/installer/fcos/e2e-ovirt f1f519f link /test pj-rehearse
ci/rehearse/openshift/installer/fcos/e2e-vsphere-upi f1f519f link /test pj-rehearse
ci/rehearse/openshift/installer/fcos/e2e-vsphere f1f519f link /test pj-rehearse
ci/rehearse/openshift/installer/fcos/e2e-gcp f1f519f link /test pj-rehearse
ci/prow/pj-rehearse f1f519f link /test pj-rehearse
ci/prow/ci-testgrid-allow-list f1f519f link /test ci-testgrid-allow-list
ci/prow/yamllint f1f519f link /test yamllint
ci/prow/boskos-config f1f519f link /test boskos-config

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

@vrutkovs: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/release-config f1f519f link /test release-config
ci/prow/boskos-config-generation f1f519f link /test boskos-config-generation
ci/prow/secret-generator-config-valid f1f519f link /test secret-generator-config-valid
ci/prow/deprecate-templates f1f519f link /test deprecate-templates

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 14, 2021

@vrutkovs: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/ci-secret-generator-config f1f519f link /test ci-secret-generator-config

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Member Author

Splitting this into several small PRs

@vrutkovs vrutkovs closed this Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gal-Zaidman Gal-Zaidman Gal-Zaidman left review comments

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vrutkovs @LorbusChris @openshift-bot @jstuever @openshift-ci-robot @Gal-Zaidman @openshift-merge-robot