OCM-11043 | test: automated case id:76543 #2606
Conversation
openshift-merge-robot
added
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jfrazierRH The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
removed
the
needs-rebase
| @@ -62,6 +62,34 @@ profiles: | |||
| account-role: | |||
| path: "/test/hcp/" | |||
| permission_boundary: "arn:aws:iam::aws:policy/AdministratorAccess" | |||
| - as: rosa-hcp-ze | |||
There was a problem hiding this comment.
what does this name:rosa-hcp-ze mean?
There was a problem hiding this comment.
Why not add zero_egress to exist profile?
There was a problem hiding this comment.
rosa-hcp-(zero egress)
I added it as a separate profile since there are restrictions about the version itself.
tests/ci/data/profiles/rosa-hcp.yaml
Outdated
| @@ -62,6 +62,34 @@ profiles: | |||
| account-role: | |||
| path: "/test/hcp/" | |||
| permission_boundary: "arn:aws:iam::aws:policy/AdministratorAccess" | |||
| - as: rosa-hcp-ze | |||
| version: 4.14.38 | |||
There was a problem hiding this comment.
How about other versions? we use latest version usually
There was a problem hiding this comment.
Currently, zero_egress is only supported for 4.14.y versions. Once the GA is released, I can change this to latest
tests/e2e/hcp_cluster_test.go
Outdated
| @@ -657,4 +658,34 @@ var _ = Describe("HCP cluster testing", | |||
| } | |||
| } | |||
| }) | |||
|
|
|||
| It("create zero-egress HCP cluster - [id:76543]", | |||
| labels.High, labels.Runtime.Day1, | |||
There was a problem hiding this comment.
I think it can move the step:CreateMachinePool in day2 case
There was a problem hiding this comment.
Even though its part of the test case? I know that having a machinepool created on a ZE cluster was an area we wanted tested.
There was a problem hiding this comment.
According to the rule, we have day1\day2\destoy ... cases. We will filter the case by orde.So if the case is for day1, it would be better to not contain day2 step. We can move it in day2 case other than ignore the step.
There was a problem hiding this comment.
No problem, I'll remove the mp portion.
|
/retest-required |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
/test e2e-presubmits-pr-rosa-sts-advanced |
|
/test e2e-presubmits-pr-rosa-hcp-advanced |
|
/retest |
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2606 +/- ##
==========================================
+ Coverage 29.41% 29.57% +0.15%
==========================================
Files 180 183 +3
Lines 24994 25156 +162
==========================================
+ Hits 7353 7440 +87
- Misses 17057 17125 +68
- Partials 584 591 +7 ☔ View full report in Codecov by Sentry. |
|
/retest |
1 similar comment
|
/retest |
|
@jfrazierRH: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
ginkgo run -focus 76543 tests/e2e
Running Suite: ROSA CLI e2e tests suite - /Users/jfrazier/workspace/rosa/tests/e2e
Random Seed: 1731037536
Will run 1 of 252 specs
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
Ran 1 of 252 Specs in 13.325 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 251 Skipped
PASS
Ginkgo ran 1 suite in 20.007141041s
Test Suite Passed