Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visibility on loading map data and sync UX #3621

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ellykits
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

ellykits and others added 5 commits October 30, 2024 18:39
Signed-off-by: Elly Kitoto <[email protected]>
Signed-off-by: Elly Kitoto <[email protected]>
* Show the LoaderDialog when syncing the Location data
Update the LoaderDialog:
    - Make box and progressBar size dynamic
    - Make the progressDialog message as optional
    - Add the ability to show either the ProgressBar or LineSpinFadeLoaderProgressIndicator

* Add an option in the LoaderDialog to show a dialog with non blocking UI
Show a non blocking dialog when applying location filtering

* clean-up: rename variables
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 282 lines in your changes missing coverage. Please review.

Project coverage is 27.1%. Comparing base (e83bd59) to head (03fe3ac).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...e/quest/ui/geowidget/GeoWidgetLauncherViewModel.kt 0.0% 107 Missing ⚠️
...core/engine/ui/components/register/LoaderDialog.kt 0.0% 67 Missing ⚠️
...rcore/quest/ui/shared/components/SyncStatusView.kt 0.0% 50 Missing ⚠️
.../components/LineSpinFadeLoaderProgressIndicator.kt 0.0% 38 Missing ⚠️
...core/quest/ui/geowidget/GeoWidgetLauncherScreen.kt 0.0% 19 Missing ⚠️
...re/quest/ui/geowidget/GeoWidgetLauncherFragment.kt 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3621     +/-   ##
=========================================
- Coverage     27.3%   27.1%   -0.2%     
- Complexity     786     787      +1     
=========================================
  Files          282     283      +1     
  Lines        14697   14808    +111     
  Branches      2635    2658     +23     
=========================================
+ Hits          4022    4023      +1     
- Misses       10129   10240    +111     
+ Partials       546     545      -1     
Flag Coverage Δ
engine 62.9% <0.0%> (-0.9%) ⬇️
geowidget 16.0% <ø> (ø)
quest 5.9% <0.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...re/quest/ui/geowidget/GeoWidgetLauncherFragment.kt 0.0% <0.0%> (ø)
...core/quest/ui/geowidget/GeoWidgetLauncherScreen.kt 0.0% <0.0%> (ø)
.../components/LineSpinFadeLoaderProgressIndicator.kt 0.0% <0.0%> (ø)
...rcore/quest/ui/shared/components/SyncStatusView.kt 0.0% <0.0%> (ø)
...core/engine/ui/components/register/LoaderDialog.kt 0.0% <0.0%> (ø)
...e/quest/ui/geowidget/GeoWidgetLauncherViewModel.kt 0.0% <0.0%> (ø)
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants