Make the preset for shop=yes unsearchable

[matkoniecz]

When you search for "shop" first match is shop=yes without even warning that it is an unspecific value, to be avoided

see also #1363 which requested opposite

[maro-21]

Thanks for the issue. I was planning to report this at some point.

We can have this preset but it should either be hidden or be at the very end (as we have for the "Point" - as a vertex).

The problem is that when you type "shop" into the search engine, shop=yes shows up first. And underneath there are 20 others, in random order and they aren't the most popular shops... The user, after looking through this list, thinks there are only so many and none match what he wants to add so he selects shop=yes. When I started my adventure with OSM and iD this is what I thought - that these are all possible shops to choose from.

[tordans]

Important

I reverted this change in #1416

I just merged #1415

This fallback preset was always present (at least 4 years). In the unsearchable shop=yes presets was introduced in 2022.

The discussion in #399 (comment) suggested that what I just merged in #1415 is a bad idea (I am re-reading that thread after merging it).

However, we now have the convention to use the "unspecified type" wording for various presets of unspecified type. And to me that is clear.

The search looked good to me as well since the matchScore makes this preset not show up really.

Please test the preview in that PR to see if you can find cases where this would be an unwanted change.

One other (or additional?) option we have is to add a ? to the Shop Icon just like we did with the Curb preset.