-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Shop" => "Shop (Unspecified type)" for the searchable shop=yes preset #1415
Conversation
The other preset is in |
🍱 You can preview the tagging presets of this pull request here. |
This will now take the existing name from https://github.com/openstreetmap/id-tagging-schema/blob/main/data/presets/shop/_yes.json |
Please read #1414 (comment) for some additional thought if we actually want this change that I just merged. |
@Dimitar5555 thanks for finding this, that was the case that I was looking for but did not manage to find when testing it yesterday. I will revert the change now so we can think, about this again… |
…openstreetmap#1415)" This reverts commit f3b9309.
…#1415)" (#1416) This reverts commit f3b9309. See #1415 (comment)
Description, Motivation & Context
This PR changes the name of the searchable
shop=yes
preset to "Shop (Unspecified type)" (was: "Shop").Related issues
#1414.
This PR addresses part of the issue:
Links and data
Relevant OSM Wiki links:
N/A
Relevant tag usage stats:
N/A
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.