Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handler struct should not contain a context #364

Open
jakedoublev opened this issue Sep 4, 2024 · 0 comments
Open

Handler struct should not contain a context #364

jakedoublev opened this issue Sep 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jakedoublev
Copy link
Contributor

Background

Recent linter work has uncovered that we are storing a context inside of the Handler struct, which is considered bad practice.

Acceptance Criteria

  1. context is removed from the Handler struct
  2. any uses have been replaced with proper contexts passed via first function arguments
@jakedoublev jakedoublev added the bug Something isn't working label Sep 4, 2024
@jakedoublev jakedoublev mentioned this issue Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jakedoublev