Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): pagination of LIST commands #447

Merged
merged 14 commits into from
Dec 5, 2024
Merged

feat(core): pagination of LIST commands #447

merged 14 commits into from
Dec 5, 2024

Conversation

jakedoublev
Copy link
Contributor

@jakedoublev jakedoublev commented Dec 3, 2024 •
edited
Loading

  1. Fixes a few bad BATS tests that used --regexp with the wrong values but passed because of more generous assert_output instead of assert_line
  2. Adds pagination info to LIST command flags and tables in a footer
  3. Adds basic BATS tests to all LIST commands
  4. Adds a comprehensive BATS test for pagination scenarios to attributes alone to avoid test redundancy

@jakedoublev jakedoublev marked this pull request as ready for review December 4, 2024 21:32
@jakedoublev jakedoublev requested a review from a team as a code owner December 4, 2024 21:32
@jakedoublev
Copy link
Contributor Author

Screenshot 2024-12-04 at 12 12 55 PM

ryanulit
ryanulit requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@ryanulit ryanulit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but just some questions about context usage...

pkg/handlers/kas-grants.go Show resolved Hide resolved
pkg/handlers/resourceMappings.go Outdated Show resolved Hide resolved
@jakedoublev jakedoublev merged commit 673a064 into main Dec 5, 2024
7 checks passed
@jakedoublev jakedoublev deleted the feat/pagination branch December 5, 2024 17:38
@opentdf-automation opentdf-automation bot mentioned this pull request Dec 5, 2024
Merged
jakedoublev pushed a commit that referenced this pull request Dec 5, 2024
@opentdf-automation
chore(main): release 0.17.0 (#440)
8267840 
🤖 I have created a release *beep* *boop*
---


##
[0.17.0](v0.16.0...v0.17.0)
(2024-12-05)


### Features

* **core:** pagination of LIST commands
([#447](#447))
([673a064](673a064))
* **core:** subject condition set prune
([#439](#439))
([c4c8b8b](c4c8b8b))


### Bug Fixes

* **core:** kas registry get should allow -i 'id' flag shorthand
([#434](#434))
([bed3701](bed3701))
* **core:** sm list should provide value fqn instead of just value
string ([#438](#438))
([9a7cb72](9a7cb72))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanulit ryanulit ryanulit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakedoublev @ryanulit