Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow no-cache client credentials options throughout CLI #142

Merged
merged 10 commits into from
May 3, 2024

Conversation

jakedoublev
Copy link
Contributor

@jakedoublev jakedoublev commented May 2, 2024

The main goal of this is to:
1. cache on the user's OS by default
2. allow auth without caching when desired (for example Ubuntu has known gnome keyring issues)
3. allow flexibility in how non-cached auth is passed into the CLI, knowing that stdin isn't always an open option for all authenticated commands
4. take inspiration from nice CLIs like gcloud --cred-file and gh --with-token
5. continue to authenticate to the platform via sdk.WithClientCredentials

Demo: https://www.loom.com/share/96327c747ad94551a7487fc51fe31a7f?sid=6e2b81e1-7fe7-4f9f-8f34-0f6dd2a23ca6

Copy link
Contributor

@suchak1 suchak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jakedoublev jakedoublev merged commit c20dc1e into main May 3, 2024
6 checks passed
@jakedoublev jakedoublev deleted the feat/auth-dynamic branch May 3, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants