Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add e2e tests for subject mappings, support for --force delete #388

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

jakedoublev
Copy link
Contributor

@jakedoublev jakedoublev commented Sep 16, 2024

Resolves #329

  • various shellcheck lint fixes found locally
  • a --force delete flag on SM
  • validation that at least one SCS flag value was added on create

@jakedoublev jakedoublev marked this pull request as ready for review September 16, 2024 22:53
@jakedoublev jakedoublev requested a review from a team as a code owner September 16, 2024 22:53
@jakedoublev jakedoublev changed the title feat(ci): add e2e tests for subject mappings feat(ci): add e2e tests for subject mappings, support for --force delete Sep 17, 2024
Copy link
Contributor

@suchak1 suchak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jakedoublev jakedoublev merged commit c1f544b into main Sep 19, 2024
10 checks passed
@jakedoublev jakedoublev deleted the feat/sm-tests branch September 19, 2024 16:47
jakedoublev pushed a commit that referenced this pull request Oct 1, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.14.0](v0.13.0...v0.14.0)
(2024-10-01)


### Features

* **ci:** add e2e tests for subject mappings, support for --force delete
([#388](#388))
([c1f544b](c1f544b))
* **ci:** add tests for subject condition sets, and --force delete flag
([#389](#389))
([c6d2abc](c6d2abc)),
closes [#331](#331)
* **ci:** e2e attribute definitions tests
([#384](#384))
([2894391](2894391)),
closes [#327](#327)
* **core:** export manual functions for CLI wrappers to consume
([#397](#397))
([aa0bf95](aa0bf95))
* **core:** resource mappings LIST fix, delete --force support, and e2e
tests ([#387](#387))
([326e74b](326e74b)),
closes [#386](#386)


### Bug Fixes

* **core:** remove duplicate titling of help manual
([#391](#391))
([cb8db69](cb8db69))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test e2e: subject mappings
2 participants