-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): adds storeFile to save encrypted profiles to disk and updates auth to propagate tlsNoVerify #420
Merged
jakedoublev
merged 23 commits into
opentdf:main
from
jgilpin:feature/update-profiles-and-auth-for-windows
Nov 15, 2024
Merged
feat(core): adds storeFile to save encrypted profiles to disk and updates auth to propagate tlsNoVerify #420
jakedoublev
merged 23 commits into
opentdf:main
from
jgilpin:feature/update-profiles-and-auth-for-windows
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… propagate tlsNoVerify
jgilpin
force-pushed
the
feature/update-profiles-and-auth-for-windows
branch
from
November 11, 2024 17:19
0a6f173
to
20c7ea2
Compare
…fine encryption Set timestamps to UTC: Updated CreatedAt and UpdatedAt timestamps in profileConfig.go to use UTC for consistent time storage. Default store type change: Changed the default store type in _index.md from keyring to file. File naming improvements: Modified hashNamespaceAndKey in storeFile.go to use a colon (:) separator for namespace and key, improving readability and consistency. File metadata handling: Enhanced handling of metadata file paths, using TrimSuffix to replace file extensions dynamically, ensuring metadata files use .nfo extension consistently across functions. Improved encryption process: Refactored encryptData to separate the nonce from the destination buffer, and prepend the nonce to ciphertext for better compatibility.
… propagate tlsNoVerify
…fine encryption Set timestamps to UTC: Updated CreatedAt and UpdatedAt timestamps in profileConfig.go to use UTC for consistent time storage. Default store type change: Changed the default store type in _index.md from keyring to file. File naming improvements: Modified hashNamespaceAndKey in storeFile.go to use a colon (:) separator for namespace and key, improving readability and consistency. File metadata handling: Enhanced handling of metadata file paths, using TrimSuffix to replace file extensions dynamically, ensuring metadata files use .nfo extension consistently across functions. Improved encryption process: Refactored encryptData to separate the nonce from the destination buffer, and prepend the nonce to ciphertext for better compatibility.
…//github.com/jgilpin/otdfctl into feature/update-profiles-and-auth-for-windows
…-profiles-and-auth-for-windows
jakedoublev
changed the title
Adds storeFile to save encrypted profiles to disk and updates auth to…
feat(core): adds storeFile to save encrypted profiles to disk and updates auth to propagate tlsNoVerify
Nov 15, 2024
jakedoublev
requested changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Jon. Here are some suggestions that should resolve the lint errors you're seeing.
jakedoublev
reviewed
Nov 15, 2024
Co-authored-by: Jake Van Vorhis <[email protected]>
Co-authored-by: Jake Van Vorhis <[email protected]>
Co-authored-by: Jake Van Vorhis <[email protected]>
Co-authored-by: Jake Van Vorhis <[email protected]>
Co-authored-by: Jake Van Vorhis <[email protected]>
Co-authored-by: Jake Van Vorhis <[email protected]>
Co-authored-by: Jake Van Vorhis <[email protected]>
Co-authored-by: Jake Van Vorhis <[email protected]>
jakedoublev
approved these changes
Nov 15, 2024
jakedoublev
pushed a commit
that referenced
this pull request
Nov 20, 2024
🤖 I have created a release *beep* *boop* --- ## [0.16.0](v0.15.0...v0.16.0) (2024-11-20) ### Features * assertion verification disable ([#419](#419)) ([acf5702](acf5702)) * **core:** add `subject-mappings match` to CLI ([#413](#413)) ([bc56c19](bc56c19)) * **core:** add optional name to kas registry CRUD commands ([#429](#429)) ([f675d86](f675d86)) * **core:** adds assertions to encrypt subcommand ([#408](#408)) ([8f0e906](8f0e906)) * **core:** adds storeFile to save encrypted profiles to disk and updates auth to propagate tlsNoVerify ([#420](#420)) ([f709e01](f709e01)) * refactor encrypt and decrypt + CLI examples ([#418](#418)) ([e681823](e681823)) * support --with-access-token for auth ([#409](#409)) ([856efa4](856efa4)) ### Bug Fixes * **core:** dev selectors employ flattening from platform instead of jq ([#411](#411)) ([57966ff](57966ff)) * **core:** improve readability of TDF methods ([#424](#424)) ([a88d386](a88d386)) * **core:** remove trailing slashes on host/platformEndpoint ([#415](#415)) ([2ffd3c7](2ffd3c7)), closes [#414](#414) * **core:** revert profiles file system storage last commit ([#427](#427)) ([79f2079](79f2079)) * updates sdk to 0.3.19 with GetTdfType fixes ([#425](#425)) ([0a9adfe](0a9adfe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.