fixing implicit nullable deprecations, bump GH actions (#1340)

* implicit nullable parameters are deprecated in 8.4, so make them explicit * update github actions versions
opentelemetry-php · Jun 28, 2024 · 1c71c0e · 1c71c0e
1 parent df4d667
commit 1c71c0e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/JaegerBaggagePropagator.php b/JaegerBaggagePropagator.php
@@ -39,7 +39,7 @@ public function fields(): array
     }
 
     /** {@inheritdoc} */
-    public function inject(&$carrier, PropagationSetterInterface $setter = null, ContextInterface $context = null): void
+    public function inject(&$carrier, ?PropagationSetterInterface $setter = null, ?ContextInterface $context = null): void
     {
         $setter ??= ArrayAccessGetterSetter::getInstance();
         $context ??= Context::getCurrent();
@@ -59,7 +59,7 @@ public function inject(&$carrier, PropagationSetterInterface $setter = null, Con
     }
 
     /** {@inheritdoc} */
-    public function extract($carrier, PropagationGetterInterface $getter = null, ContextInterface $context = null): ContextInterface
+    public function extract($carrier, ?PropagationGetterInterface $getter = null, ?ContextInterface $context = null): ContextInterface
     {
         $getter ??= ArrayAccessGetterSetter::getInstance();
         $context ??= Context::getCurrent();

diff --git a/JaegerPropagator.php b/JaegerPropagator.php
@@ -51,7 +51,7 @@ public function fields(): array
     }
 
     /** {@inheritdoc} */
-    public function inject(&$carrier, PropagationSetterInterface $setter = null, ContextInterface $context = null): void
+    public function inject(&$carrier, ?PropagationSetterInterface $setter = null, ?ContextInterface $context = null): void
     {
         $setter ??= ArrayAccessGetterSetter::getInstance();
         $context ??= Context::getCurrent();
@@ -75,7 +75,7 @@ public function inject(&$carrier, PropagationSetterInterface $setter = null, Con
     }
 
     /** {@inheritdoc} */
-    public function extract($carrier, PropagationGetterInterface $getter = null, ContextInterface $context = null): ContextInterface
+    public function extract($carrier, ?PropagationGetterInterface $getter = null, ?ContextInterface $context = null): ContextInterface
     {
         $getter ??= ArrayAccessGetterSetter::getInstance();
         $context ??= Context::getCurrent();