-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead code in pallet-subtensor #1036
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-otf
force-pushed
the
chore/cleanup-pallet-subtensor
branch
4 times, most recently
from
November 28, 2024 19:10
7165d13
to
3fa8526
Compare
distributedstatemachine
requested changes
Nov 29, 2024
ales-otf
force-pushed
the
chore/cleanup-pallet-subtensor
branch
2 times, most recently
from
November 29, 2024 15:22
72e4b73
to
1480eba
Compare
distributedstatemachine
previously approved these changes
Nov 29, 2024
gztensor
previously approved these changes
Nov 29, 2024
ales-otf
dismissed stale reviews from gztensor and distributedstatemachine
via
December 2, 2024 16:59
69cc4ce
ales-otf
force-pushed
the
chore/cleanup-pallet-subtensor
branch
2 times, most recently
from
December 3, 2024 14:48
69cc4ce
to
beec04f
Compare
ales-otf
force-pushed
the
chore/cleanup-pallet-subtensor
branch
from
December 4, 2024 21:45
1fc94ea
to
6bb1afe
Compare
ales-otf
added
the
skip-cargo-audit
This PR fails cargo audit but needs to be merged anyway
label
Dec 4, 2024
sam0x17
approved these changes
Dec 4, 2024
This was referenced Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes dead methods and types listed below.
Methods:
get_normalized_stake
get_number_of_subnets
get_total_hotkey_delegated_stake
get_validator_prune_len
has_axon_info
has_prometheus_info
Remove dead code in pallet-subtensor #1036 (comment)is_registration_allowed
passes_rate_limit_globally
set_balance_on_coldkey_account
set_last_tx_block_childkey_take
Error variants:
NewColdKeyIsSameWithOld
ColdKeySwapTxRateLimitExceeded
NotExistColdkey
NoBalanceToTransfer
SameColdkey
DuplicateColdkey
ColdkeySwapError
InsufficientBalanceToPerformColdkeySwap
MaxColdkeyDestinationsReached
SwapColdkeyOnlyCallableByRoot
NewColdkeyIsInArbitration
Related Issue(s)
Type of Change
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctly