Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Publisher Only role #313

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Added Publisher Only role #313

merged 3 commits into from
Mar 22, 2024

Conversation

dragonmantank
Copy link
Contributor

What is this PR doing?

Adding the new "publisher-only" role for token generation

How should this be manually tested?

This will be tested with the JS client SDK

What are the relevant tickets?

TBD, but trust me there will be JIRA tickets

@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (111be34) 63.5% compared to head (cf458b7) 81.5%.
Report is 7 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
lib/render.js 19.6% <33.3%> (-2.0%) ⬇️
lib/opentok.js 76.4% <33.3%> (-0.4%) ⬇️

... and 7 files with indirect coverage changes

@dragonmantank dragonmantank marked this pull request as draft October 12, 2023 17:22
@dragonmantank dragonmantank marked this pull request as ready for review March 22, 2024 14:41
@dragonmantank dragonmantank merged commit 3807993 into main Mar 22, 2024
12 checks passed
@dragonmantank dragonmantank deleted the publisher-only branch March 22, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Do Not Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragonmantank @pardel