Add fallback name for corridors #6303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6303 +/- ##
==========================================
Coverage 69.79% 69.79%
- Complexity 17786 17787 +1
==========================================
Files 2017 2017
Lines 76042 76043 +1
Branches 7781 7781
==========================================
+ Hits 53073 53074 +1
Misses 20264 20264
Partials 2705 2705 ☔ View full report in Codecov by Sentry. |
leonardehrenfried
changed the title
leonardehrenfried
force-pushed
the
corridor-name
branch
from
9d437bd to
d7fd1d8
Compare
|
@vesameskanen Could you please review this? |
binh-dam-ibigroup
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Many types of OSM ways have a fallback name like "path", "stairs" or "tunnel" but those tagged with
highway=corridordo not. This PR adds it.Unit tests
Added.