StaticLLMPipeline: Use set_tensor for kvcache model #1106
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TolyaTalamanov
commented
Oct 30, 2024
| @@ -704,6 +704,17 @@ EncodedResults StaticLLMPipeline::generate( | |||
| position_ids_data[0] = m_kvcache_desc.num_stored_tokens; | |||
| attention_mask_data[m_kvcache_desc.num_stored_tokens - 1] = 1u; | |||
|
|
|||
| // NB: Write KV-cache for the new token to the correct input position for the next iteration | |||
There was a problem hiding this comment.
Comment should be changed
There was a problem hiding this comment.
@TolyaTalamanov Does set_tensor now support remote tensor data sharing across CPU and NPU?
github-actions
bot
added
category: LLM
|
@TolyaTalamanov did it change anything? |
It broke accuracy, although on CPU it works fine. Will re-consider this optimization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.