Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed passing of generation config params to VLM generate. #1180

Merged
merged 16 commits into from
Nov 20, 2024
Merged

Fixed passing of generation config params to VLM generate. #1180

merged 16 commits into from
Nov 20, 2024

Conversation

popovaan
Copy link
Contributor

@popovaan popovaan commented Nov 8, 2024 •
edited by andrei-kochin
Loading

  • Fixed passing of generation config params to VLM generate().
  • Updated generation config params params list in update_config_from_kwargs() method.

Ticket: CVS-157050

@popovaan popovaan marked this pull request as ready for review November 8, 2024 16:19
@github-actions github-actions bot added category: visual language Visual language pipeline category: sampling Sampling / Decoding algorithms category: Python API Python API for GenAI labels Nov 8, 2024
@ilya-lavrenov ilya-lavrenov modified the milestones: 2025.0, 2024.5 Nov 8, 2024
@ilya-lavrenov
Copy link
Contributor

Let' submit fix to 2024.5

@ilya-lavrenov ilya-lavrenov added the bug Something isn't working label Nov 8, 2024
@ilya-lavrenov ilya-lavrenov self-assigned this Nov 8, 2024
@popovaan popovaan mentioned this pull request Nov 11, 2024
Merged
Wovchena
Wovchena requested changes Nov 11, 2024
View reviewed changes
src/python/py_utils.hpp Outdated Show resolved Hide resolved
src/python/py_utils.cpp Show resolved Hide resolved
github-merge-queue bot pushed a commit that referenced this pull request Nov 11, 2024
@ilya-lavrenov
Fixed passing of generation config params to VLM generate. (#1184)
a566870 
Fixed passing of generation config params to VLM generate.
Port of #1180
@ilya-lavrenov ilya-lavrenov modified the milestones: 2024.5, 2025.0 Nov 11, 2024
@github-actions github-actions bot added category: text to image Text 2 image pipeline category: whisper Whisper pipeline category: GenAI C++ API Changes in GenAI C++ public headers labels Nov 16, 2024
@github-actions github-actions bot added the category: LLM LLM pipeline (stateful, static) label Nov 16, 2024
ilya-lavrenov
ilya-lavrenov reviewed Nov 16, 2024
View reviewed changes
src/python/py_utils.cpp Show resolved Hide resolved
src/python/py_utils.cpp Show resolved Hide resolved
src/python/py_utils.cpp Outdated Show resolved Hide resolved
src/python/py_utils.cpp Show resolved Hide resolved
src/python/py_utils.cpp Outdated Show resolved Hide resolved
Wovchena
Wovchena previously requested changes Nov 19, 2024
View reviewed changes
src/python/py_utils.cpp Outdated Show resolved Hide resolved
src/python/py_utils.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot added the category: tokenizers Tokenizer class or submodule update label Nov 19, 2024
ilya-lavrenov
ilya-lavrenov reviewed Nov 19, 2024
View reviewed changes
src/python/py_utils.cpp Outdated Show resolved Hide resolved
src/cpp/src/llm_pipeline_static.cpp Outdated Show resolved Hide resolved
@popovaan @ilya-lavrenov
Update src/python/py_utils.cpp
1978b67 
Co-authored-by: Ilya Lavrenov <[email protected]>
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue Nov 20, 2024
Merged via the queue into openvinotoolkit:master with commit cd05c8e Nov 20, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wovchena Wovchena Wovchena left review comments

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@slyalin slyalin Awaiting requested review from slyalin

Assignees

@ilya-lavrenov ilya-lavrenov

Labels
bug Something isn't working category: continuous batching Continuous batching category: GenAI C++ API Changes in GenAI C++ public headers category: LLM LLM pipeline (stateful, static) category: Python API Python API for GenAI category: sampling Sampling / Decoding algorithms category: text to image Text 2 image pipeline category: tokenizers Tokenizer class or submodule update category: visual language Visual language pipeline category: whisper Whisper pipeline no-match-files
Projects
None yet
Milestone
2025.0
Development

Successfully merging this pull request may close these issues.
4 participants
@popovaan @ilya-lavrenov @Wovchena @slyalin