chore: initial cleanup and scripts for 0.5.0 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
berendsliedrecht
approved these changes
Feb 1, 2024
Co-authored-by: Berend Sliedrecht <[email protected]> Signed-off-by: Timo Glastra <[email protected]>
genaris
reviewed
Feb 1, 2024
| @@ -13,7 +13,7 @@ jobs: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: 16.x | |||
| node-version: 18.x | |||
| cache: yarn | |||
|
|
|||
| # ignore scripts as indy-sdk will try to build and we don't have libindy | |||
There was a problem hiding this comment.
This can now be deleted in the CI scripts?
There was a problem hiding this comment.
Not yet as indy-sdk is still included for 0.3/0.4 snippets
| @@ -15,7 +15,7 @@ jobs: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: 16.x | |||
| node-version: 18.x | |||
| cache: yarn | |||
|
|
|||
| # ignore scripts as indy-sdk will try to build and we don't have libindy | |||
| @@ -31,7 +31,7 @@ You can do this directly on your machine. | |||
| After installing and confirming that Libindy is installed, simply run: | |||
There was a problem hiding this comment.
I guess @credo-ts/rest will be available as soon as we get the 0.5.0 release. In such case Libindy will not be needed, right?
There was a problem hiding this comment.
I'm working on updating the REST PR and then releasing a new version. Will update there accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@credo-tsIn a follow up PR i'll add the migration guide