-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nats package #88
base: master
Are you sure you want to change the base?
Add nats package #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a README.md file which explain how the package should be used, and maybe godoc for the most important file
nats/handler.go
Outdated
|
||
// For Checking compatibility | ||
var ( | ||
_ EventHandler = (*NatsEventHandler)(nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I prefer to put those lines into the test file, even in a test so it's more clear this is testing the interface compliance. It can eventually save few bytes of memory footprint.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
No description provided.