When typing in a MathQuill input, update positions of all feedback popovers. #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
another-feedback-position-update
branch
from
58c3d1f
to
18bc404
Compare
somiaj
approved these changes
Oct 1, 2024
drgrice1
force-pushed
the
another-feedback-position-update
branch
from
18bc404
to
357841e
Compare
drgrice1
force-pushed
the
another-feedback-position-update
branch
from
357841e
to
9883ba3
Compare
drgrice1
force-pushed
the
another-feedback-position-update
branch
from
9883ba3
to
f9e94d1
Compare
…input, Don't only update the popover corresponding to the input that is currently being typed in. This fixes the issue reported by @somiaj in openwebwork#1110 (comment).
drgrice1
force-pushed
the
another-feedback-position-update
branch
from
f9e94d1
to
6c00377
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue reported by @somiaj in
#1110 (comment).