Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape pattern for EV3P for perl/latex brace conflict (hotfix) #916

Closed
wants to merge 1 commit into from

Conversation

Alex-Jordan
Copy link
Contributor

This is an alternative to #915, as mentioned there. This approach escapes a brace that we are pretty sure is not intended to be part of a perl hash value accessor. I lean toward this approach since it doesn't require macro authors to know about the underlying issue with braces. And if it needs adjusting, it's just in one place.

This is a conservative regex pattern that only escapes the brace if followed by backslash,backslash,not-backslash. It could be a little less conservative. Or a lot less conservative like s/\{(?!\s*[\$\w])/\\\{/g, always escaping a brace unless it is followed by a word character or a dollar sign, which could indicate the brace was indeed meant to be part of a hash value accessor.

I'll wait for discussion to see if this goes forward ro needs changing, before opening a develop version.

@drgrice1
Copy link
Member

I think you have not yet seen my comment at #914 (comment). As per that comment, this should be targeted for develop, and adjusted a bit.

@Alex-Jordan
Copy link
Contributor Author

Closing in favor of #914, #915, and #917.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants