escape pattern for EV3P for perl/latex brace conflict (hotfix) #916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #915, as mentioned there. This approach escapes a brace that we are pretty sure is not intended to be part of a perl hash value accessor. I lean toward this approach since it doesn't require macro authors to know about the underlying issue with braces. And if it needs adjusting, it's just in one place.
This is a conservative regex pattern that only escapes the brace if followed by backslash,backslash,not-backslash. It could be a little less conservative. Or a lot less conservative like
s/\{(?!\s*[\$\w])/\\\{/g
, always escaping a brace unless it is followed by a word character or a dollar sign, which could indicate the brace was indeed meant to be part of a hash value accessor.I'll wait for discussion to see if this goes forward ro needs changing, before opening a
develop
version.