Protect EV3P command output from variable substitution. #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
EV3P-protect-command-output
branch
2 times, most recently
from
e7b0aa8 to
55c1156
Compare
pstaabp
approved these changes
Aug 24, 2023
drgrice1
force-pushed
the
EV3P-protect-command-output
branch
from
55c1156 to
73e7db8
Compare
This an alternate to openwebwork#917 (and openwebwork#914) to fix issue openwebwork#912. This uses the technique described by @dpvc in openwebwork#914 (comment) with a minor tweak to limit the scope of `$__blank__`. Here is a MWE with all of the issues that have been brought up: ```perl DOCUMENT(); loadMacros('PGstandard.pl', 'MathObjects.pl'); $x = "one"; $xx = "two"; $xxx = "three"; $y = '$x'; BEGIN_TEXT $DOLLAR\{ ans_rule(1) \} $PAR $x\{"x"\} and $x\{"x"\}x and \{$y\}x END_TEXT ANS(Real(1)->cmp); ENDDOCUMENT(); ``` With the develop branch the above example will work in html, but the output on the second line will be "two and three and two". With this pull request the output on the second line will be "onex and onexx and onex". With the develop branch the above example will not work in hardcopy, but with this branch it will.
drgrice1
force-pushed
the
EV3P-protect-command-output
branch
from
73e7db8 to
54dc0ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This an alternate to #917 (and #914) to fix issue #912. This uses the technique described by @dpvc in
#914 (comment) with a minor tweak to limit the scope of
$__blank__.Here is a MWE with all of the issues that have been brought up:
With the develop branch the above example will work in html, but the output on the second line will be "two and three and two". With this pull request the output on the second line will be "onex and onexx and onex".
With the develop branch the above example will not work in hardcopy, but with this branch it will.