-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a convenience subroutine for getting a simplified radical expression #932
add a convenience subroutine for getting a simplified radical expression #932
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this would probably fit better somewhere else. This method could be useful in many situations where the contextLimitedRadical.pl
is not needed. I am not sure where exactly to advise you to put this though.
This is old code that I just submitted as it was. I should have reviewed it for inefficiencies or other ugliness. I'll make changes, probably exactly as you suggest, soon. |
f36100e
to
156d335
Compare
I committed your suggestion plus one minor cleanup. Still not sure where to put this other than here. It returns a |
156d335
to
8faa63b
Compare
8faa63b
to
0e7cf9f
Compare
0e7cf9f
to
7aec500
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this. I don't think anyone has found a better place for it.
7aec500
to
19675f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's put it in.
This macro was previously in the PCC section of the OPL macros. This addition is a tool we have used in some problem files. It's simplest on my end to leave it here, but I acknowledge it may be a better fit somewhere else...