[feature] Allowed deploying WPA Enterprise 2 TTLS-PAP #462 #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
requested changes
May 23, 2024
There was a problem hiding this comment.
Good progress @pandafy, can you add this functionality to the test playbook so we can have some basic test coverage for it?
Please also see my comments below.
pandafy
force-pushed
the
issues/462-deploying-wpa-enterprise-ttls
branch
from
c626fe1
to
098b58d
Compare
nemesifier
requested changes
May 29, 2024
There was a problem hiding this comment.
One problem found during testing: the calling station ID will be the wifi interface, which is not the same of the mac address of the device. This will make it hard to connect the device to the radius accounting session.
Can you try changing the mac address of the wifi interface by using the {{mac_address}} variable?
I just tried this and it worked (I had to bring down and up the interface manually, openwrt did not update the mac address on its own).
It would be great to recommend this in the tutorial.
Made file names consistent
pandafy
force-pushed
the
issues/462-deploying-wpa-enterprise-ttls
branch
from
188147b
to
7d9158c
Compare
pandafy
force-pushed
the
issues/462-deploying-wpa-enterprise-ttls
branch
from
43ce2cf
to
c0e7161
Compare
nemesifier
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #462