[change!] Fixed the URL structure for downloading CA's CRL

openwisp · Jul 26, 2024 · cfe3d62 · cfe3d62
1 parent 131d5e5
commit cfe3d62
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/django_x509/base/admin.py b/django_x509/base/admin.py
@@ -135,9 +135,7 @@ class Media:
         js = ('admin/js/jquery.init.js', 'django-x509/js/x509-admin.js')
 
     def get_urls(self):
-        return [
-            path('x509/ca/<int:pk>.crl', self.crl_view, name='crl')
-        ] + super().get_urls()
+        return [path('<int:pk>.crl', self.crl_view, name='crl')] + super().get_urls()
 
     def crl_view(self, request, pk):
         authenticated = request.user.is_authenticated

diff --git a/django_x509/tests/test_ca.py b/django_x509/tests/test_ca.py
@@ -20,6 +20,8 @@ class TestCa(TestX509Mixin, TestCase):
     tests for Ca model
     """
 
+    app_label = Ca._meta.app_label
+
     def _prepare_revoked(self):
         ca = self._create_ca()
         crl = crypto.load_crl(crypto.FILETYPE_PEM, ca.crl)
@@ -313,7 +315,9 @@ def test_crl(self):
 
     def test_crl_view(self):
         ca, cert = self._prepare_revoked()
-        response = self.client.get(reverse('admin:crl', args=[ca.pk]))
+        path = reverse('admin:crl', args=[ca.pk])
+        self.assertEqual(path, f'/admin/{self.app_label}/ca/{ca.pk}.crl')
+        response = self.client.get(path)
         self.assertEqual(response.status_code, 200)
         crl = crypto.load_crl(crypto.FILETYPE_PEM, response.content)
         revoked_list = crl.get_revoked()