[fix] Config editor issues #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For select fields, with predefined values in the corresponding JSON schema, when a value is saved other than the default, the field will be empty after saving in the Device config editor. This happens only, in combination of the lib select2. The cause of the issue is, that the jsonschema-ui.js version does use a deprecated way to initialize select2 inputs. This commit will fix this issue by updating the way of initializing the inputs. Fixes #910 Signed-off-by: Konrad Kreitmair <[email protected]>
…910 This addresses the problem, that the drop-down for Configuration Menu and Object Properties are not shown anymore in the device config editor, if a configuration section is saved, which has in its JSON schema definition a property with type array and should have unique items. The cause of the problem is a call to super, when there is no super. This commit will fix this issue by removing the call to super, because it is not needed in this special case neither in all other cases. Fixes #910 Signed-off-by: Konrad Kreitmair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Reference to Existing Issue
Closes #910.
Description of Changes
To address the first Issue described in #910, an update of the way the selects are initialized by the jsonschema-ui.js is needed.
To address the second Issue described in #910, a call to super has to be removed, because it is not needed in this special case neither in all other cases.