[gsoc] Added project idea for improving the general map: mobile locations, indoor map, linkable URLs #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
force-pushed
the
gsoc-maps-project
branch
from
347f13b
to
3784490
Compare
pandafy
force-pushed
the
gsoc-maps-project
branch
from
3784490
to
2cccdcc
Compare
nemesifier
requested changes
Feb 10, 2024
There was a problem hiding this comment.
@pandafy it's looking better, I made some improvements and while doing so I noticed that I think there's no mention of some important points:
- There was no mention of netjsongraph.js! I added it. It's important that contributors get acquainted with this library.
- We said from the device detail page we want to find a way to allow the user to see the device in the general map, we were thinking of linking to a URL to the dedicated view of the general map, but the map bust have a mechanism that allows URLs to point to specific devices, now we don't have such a mechanism. If we link to the general map now we don't have a way to open a specific device and zoom in, is this clear?
- Same as above but for the indoor view.
nemesifier
changed the title
pandafy
force-pushed
the
gsoc-maps-project
branch
from
c477ecb
to
a7c1c9a
Compare
nemesifier
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.