Add SIMD metadata in /proc on Linux follow up #16552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change accidentally broke the FreeBSD build due to a conflict between the simd_stat_init()/simd_stat_fini() macro on FreeBSD and the extern function prototype. Signed-off-by: Brian Behlendorf <[email protected]>
tonyhutter
approved these changes
Sep 20, 2024
behlendorf
added
Status: Accepted
mcmilk
pushed a commit
to mcmilk/zfs
that referenced
this pull request
Sep 21, 2024
This change accidentally broke the FreeBSD build due to a conflict between the simd_stat_init()/simd_stat_fini() macros on FreeBSD and the extern function prototype. Reviewed-by: Tony Hutter <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#16552
ptr1337
pushed a commit
to CachyOS/zfs
that referenced
this pull request
Nov 14, 2024
This change accidentally broke the FreeBSD build due to a conflict between the simd_stat_init()/simd_stat_fini() macros on FreeBSD and the extern function prototype. Reviewed-by: Tony Hutter <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#16552
ptr1337
pushed a commit
to CachyOS/zfs
that referenced
this pull request
Nov 21, 2024
This change accidentally broke the FreeBSD build due to a conflict between the simd_stat_init()/simd_stat_fini() macros on FreeBSD and the extern function prototype. Reviewed-by: Tony Hutter <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#16552
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Follow up for #16530 where I rushed the merge and broke the FreeBSD. Let me clean up my mess.
Description
This change accidentally broke the FreeBSD build due to a conflict between the simd_stat_init()/simd_stat_fini() macro on FreeBSD and the extern function prototype.
How Has This Been Tested?
Locally build on Linux will be checked by the CI for FreeBSD.
Types of changes
Checklist:
Signed-off-by.