-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement REPARSE POINTS #161
base: master
Are you sure you want to change the base?
Conversation
@@ -542,8 +543,7 @@ int zfs_find_dvp_vp(zfsvfs_t *zfsvfs, char *filename, int finalpartmaynotexist, | |||
return 0; | |||
} | |||
|
|||
static ULONG zp_get_reparse_tag(znode_t *zp); | |||
// There are multiple struct types with "stat" style members. | |||
// There are multiple sturct types with "stat" style members. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a typo, right? :D "sturct"
@lundman I added you as a collaborator on my fork so you can push changes required for this PR. Thanks again. |
There was also a bit more work here: https://github.com/DHowett/ZFSin/commits/rp_synth2
|
Quite interesting - even knowing the names like
Is it acceptable then to store the reparse points in symlink data ( I'll create a parallel PR to this, as your code gets merged into master - probably the easiest way for us to keep an eye on code changes. |
I'm getting increasingly more unhappy with At the very least, wrap it in one more function, so we don't have to repeat the cleanup code so many times. It seems clear that QOC should be done for file and dirs, for existing and creating, so adding 4 copies of the same code is dumb. Anyway, head's up I'm about to break it :) |
In an attempt to be compatible with existing reparse points (EA stored) - for example samba implementation.
I believe this is not complete, but a starting point - there are also some cross over with master.