-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection View #47
Collection View #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you! Here's what I found:
- Doesn't scale well to high resolution: sidebar gets too wide (see screenshot)
- there should be a cursor change on project hover to hint user into knowing double-click allows renaming
- Hitting enter on renaming should focus out/exit the renaming field. Escape should cancel.
- Hover effect on project line is odd: text moves (vertically) a bit in a disturbing way
- I'd like to see FAQ and contact links working (to static lorem ipsum page for now)
- No confirmation on Project deletion (!!!)
- New user dragging files doesn't arrive to the sidebar version of the project view.
I want to acknowledge the fact that there is no per-project URL. It's fine since this is purely private and not shareable. Also, we record the last selected project_id.
These should be done.
I only have a 4K monitor, but there doesn't seem to be width issue on macOS. I toned down the width of the siderbar in hopes of fixing this.
I don't quite understand it. I remember we didn't want the user to jump to the collection view when they were using it for the first time, instead we just want they to view the Project View(without sidebar), correct me if I'm wrong. Anyway I also add it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you; here's what I found this time:
- Obviously both FAQ and Contact must appear with the Sidebar. Once you've got a valid userId, then you're a user and you have the regular (Sidebar) UI. Home is the exception.
- I see no cursor change indicating I can change the project name
- While enter key works as expected, escape doesn't. It doesn't cancel current edit but reverts to
New Project
. That's not convenient at all. - I've renamed my project to
New Project2
. Then wanted to rename it to something else but hit espace, so I got backNew Project
(unexpectedly as mentioned above). Now trying to delete it, the modal saysNew Project2
but the sidebar has the other name. This is wrong (see screenshot)
And ignore format commits, my editor's formatter has conflicts with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
Goal
The goal of this PR is to complete the Collection View in #40.
Abstract