Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection View #47

Merged
merged 34 commits into from
Aug 21, 2023
Merged

Collection View #47

merged 34 commits into from
Aug 21, 2023

Conversation

FledgeXu
Copy link
Collaborator

@FledgeXu FledgeXu commented Aug 17, 2023

Goal

The goal of this PR is to complete the Collection View in #40.

Abstract

  • Projects sidebar (functional)
    • Add Project
    • Delete Project
    • Change Project Name
    • Redirect to Collection View When clients have created the user.

frontend/src/components/SideBarComponent.vue Outdated Show resolved Hide resolved
frontend/src/views/StartView.vue Show resolved Hide resolved
frontend/src/components/ProjectColumnComponent.vue Outdated Show resolved Hide resolved
@FledgeXu FledgeXu requested a review from rgaudin August 17, 2023 15:27
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you! Here's what I found:

  • Doesn't scale well to high resolution: sidebar gets too wide (see screenshot)
  • there should be a cursor change on project hover to hint user into knowing double-click allows renaming
  • Hitting enter on renaming should focus out/exit the renaming field. Escape should cancel.
  • Hover effect on project line is odd: text moves (vertically) a bit in a disturbing way
  • I'd like to see FAQ and contact links working (to static lorem ipsum page for now)
  • No confirmation on Project deletion (!!!)
  • New user dragging files doesn't arrive to the sidebar version of the project view.

I want to acknowledge the fact that there is no per-project URL. It's fine since this is purely private and not shareable. Also, we record the last selected project_id.

Screenshot 2023-08-17 at 17 45 29

frontend/src/components/ProjectColumnComponent.vue Outdated Show resolved Hide resolved
frontend/src/components/SideBarComponent.vue Outdated Show resolved Hide resolved
frontend/src/components/SideBarComponent.vue Outdated Show resolved Hide resolved
frontend/src/router/index.ts Outdated Show resolved Hide resolved
frontend/src/views/CollectionView.vue Outdated Show resolved Hide resolved
frontend/src/views/StartView.vue Outdated Show resolved Hide resolved
frontend/src/views/StartView.vue Show resolved Hide resolved
frontend/src/components/ProjectColumnComponent.vue Outdated Show resolved Hide resolved
@FledgeXu
Copy link
Collaborator Author

  • there should be a cursor change on project hover to hint user into knowing double-click allows renaming
  • Hitting enter on renaming should focus out/exit the renaming field. Escape should cancel.
  • Hover effect on project line is odd: text moves (vertically) a bit in a disturbing way
  • I'd like to see FAQ and contact links working (to static lorem ipsum page for now)
  • No confirmation on Project deletion (!!!)

These should be done.

  • Doesn't scale well to high resolution: sidebar gets too wide (see screenshot)

I only have a 4K monitor, but there doesn't seem to be width issue on macOS. I toned down the width of the siderbar in hopes of fixing this.

  • New user dragging files doesn't arrive to the sidebar version of the project view.

I don't quite understand it. I remember we didn't want the user to jump to the collection view when they were using it for the first time, instead we just want they to view the Project View(without sidebar), correct me if I'm wrong. Anyway I also add it.

@FledgeXu FledgeXu requested a review from rgaudin August 18, 2023 17:23
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you; here's what I found this time:

  • Obviously both FAQ and Contact must appear with the Sidebar. Once you've got a valid userId, then you're a user and you have the regular (Sidebar) UI. Home is the exception.
  • I see no cursor change indicating I can change the project name
  • While enter key works as expected, escape doesn't. It doesn't cancel current edit but reverts to New Project. That's not convenient at all.
  • I've renamed my project to New Project2. Then wanted to rename it to something else but hit espace, so I got back New Project (unexpectedly as mentioned above). Now trying to delete it, the modal says New Project2 but the sidebar has the other name. This is wrong (see screenshot)
Screenshot 2023-08-18 at 18 32 29

frontend/src/components/ModalComponent.vue Outdated Show resolved Hide resolved
frontend/src/stores/stores.ts Outdated Show resolved Hide resolved
@FledgeXu
Copy link
Collaborator Author

FledgeXu commented Aug 21, 2023

  1. Now put your pointer over Project Name and you should be prompted that Project Name can be edited
  2. Weird name status should be fixed.
  3. When updating failed, project's name will be reset to previous one.

And ignore format commits, my editor's formatter has conflicts with yarn format

@FledgeXu FledgeXu requested a review from rgaudin August 21, 2023 15:24
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@rgaudin rgaudin merged commit 37431e7 into main Aug 21, 2023
2 checks passed
@rgaudin rgaudin deleted the collection-view branch August 21, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants