-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Archive management #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rgaudin
commented
Aug 23, 2024
- Allows setting/updating metadata
- Allows requesting archive
- Displays archive requests with download link
- Handles zimfarm/hook/email
new deps: smart-tagz for ZIM tags edition luxon for datetime formatting
- main-logo part of archive config - saved in base64 as is illustration - uploaded upon request - email can be set upon request - new image updated component for illustration and main-logo
- fixed email templates access - added zim_download_url as this is only controled by ZF ATM - fixed date parsing from ZF payload - dont commit inside hook (we dont need out-of-session direct access) - fixed mailgun call (as our target is a single email) - using correct download url in template - allow overriding mailgun and other in .env (dev)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 77.08% 74.11% -2.97%
==========================================
Files 18 18
Lines 912 962 +50
Branches 105 115 +10
==========================================
+ Hits 703 713 +10
- Misses 187 226 +39
- Partials 22 23 +1 ☔ View full report in Codecov by Sentry. |
rgaudin
force-pushed
the
update-archive-metadata
branch
from
August 23, 2024 19:16
6cbce47
to
3de4f75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.