Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Archive management #70

Merged
merged 24 commits into from
Aug 23, 2024
Merged

Basic Archive management #70

merged 24 commits into from
Aug 23, 2024

Conversation

rgaudin
Copy link
Member

@rgaudin rgaudin commented Aug 23, 2024

  • Allows setting/updating metadata
  • Allows requesting archive
  • Displays archive requests with download link
  • Handles zimfarm/hook/email

new deps:
smart-tagz for ZIM tags edition
luxon for datetime formatting
- main-logo part of archive config
- saved in base64 as is illustration
- uploaded upon request
- email can be set upon request
- new image updated component for illustration and main-logo
- fixed email templates access
- added zim_download_url as this is only controled by ZF ATM
- fixed date parsing from ZF payload
- dont commit inside hook (we dont need out-of-session direct access)
- fixed mailgun call (as our target is a single email)
- using correct download url in template
- allow overriding mailgun and other in .env (dev)
@rgaudin rgaudin self-assigned this Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 48.93617% with 48 lines in your changes missing coverage. Please review.

Project coverage is 74.11%. Comparing base (1e23ced) to head (3de4f75).
Report is 25 commits behind head on main.

Files Patch % Lines
backend/api/routes/archives.py 38.46% 39 Missing and 1 partial ⚠️
backend/api/routes/__init__.py 16.66% 5 Missing ⚠️
backend/api/zimfarm.py 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #70      +/-   ##
==========================================
- Coverage   77.08%   74.11%   -2.97%     
==========================================
  Files          18       18              
  Lines         912      962      +50     
  Branches      105      115      +10     
==========================================
+ Hits          703      713      +10     
- Misses        187      226      +39     
- Partials       22       23       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rgaudin rgaudin merged commit bd70033 into main Aug 23, 2024
4 of 6 checks passed
@rgaudin rgaudin deleted the update-archive-metadata branch August 23, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant