Skip to content

Commit

Permalink
Merge pull request #407 from openzim/fix_help
Browse files Browse the repository at this point in the history
Fix help and add test case to check this important feature
  • Loading branch information
benoit74 authored Oct 8, 2024
2 parents 9bf3ea4 + 0e69193 commit e8faebb
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/workflows/Tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ jobs:
- name: build image
run: docker build -t zimit .

- name: ensure help display without issue
run: docker run -v $PWD/output:/output zimit zimit --help

- name: run crawl
run: docker run -v $PWD/output:/output zimit zimit --url http://isago.rskg.org/ --name isago --zim-file isago.zim --adminEmail [email protected] --mobileDevice "Pixel 5" --statsFilename /output/stats.json --keep

Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Upgrade to browsertrix crawler 1.3.2, warc2zim 2.1.2 and other dependencies (#406)

### Fixed

- Fix help (#393)

## [2.1.2] - 2024-09-09

### Changed
Expand Down
2 changes: 1 addition & 1 deletion src/zimit/zimit.py
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ def run(raw_args):
parser.add_argument(
"--diskUtilization",
help="Save state and exit if disk utilization exceeds this percentage value."
" Default (if not set) is 90%. Set to 0 to disable disk utilization check.",
" Default (if not set) is 90%%. Set to 0 to disable disk utilization check.",
type=int,
default=90,
)
Expand Down

0 comments on commit e8faebb

Please sign in to comment.