Updates to latest build and latest Brave #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2024 11:45
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
commented
Jan 8, 2024
| </properties> | ||
|
|
||
| <dependencyManagement> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.apache.cassandra</groupId> | ||
| <artifactId>cassandra-all</artifactId> | ||
| <!-- Matches last zipkin test image (v2.23.7) --> | ||
| <version>3.11.9</version> |
There was a problem hiding this comment.
last zipkin test image for cassandra 3.x a separate PR can try 4.x
| <junit-jupiter.version>5.7.0</junit-jupiter.version> | ||
| <assertj.version>3.18.1</assertj.version> | ||
| <testcontainers.version>1.15.1</testcontainers.version> | ||
| <cassandra-driver-core.version>3.11.2</cassandra-driver-core.version> |
There was a problem hiding this comment.
last of this driver version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates all tests and fixtures from JUnit 4.x to Jupiter. Notably, this allows use of latest brave 5.18.
After manually converting the build to latest, I began porting by using this command from @TeamModerne, which got surprisingly far despite this being a very complex project.
After that, I focused on the following areas which led to conclusion: