Skip to content

Commit

Permalink
Works around inheritance that results in an empty DEPENDENCIES file (#39
Browse files Browse the repository at this point in the history
)

org.apache:apache:21 sets maven-remote-resources-plugin in plugins, not pluginManagement
This results in execution in the parent project, and a side effect of an empty
DEPENDENCIES file in the assembly when packaged with the apache-release profile.

https://issues.apache.org/jira/browse/MPOM-218

This works around the problem by skipping at the parent level at the cost of having to
un-skip it at every deployed child.
  • Loading branch information
adriancole authored Feb 19, 2019
1 parent 57db488 commit 4c57150
Show file tree
Hide file tree
Showing 5 changed files with 40 additions and 0 deletions.
6 changes: 6 additions & 0 deletions exporter-sender-kafka/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@

<build>
<plugins>
<plugin>
<artifactId>maven-remote-resources-plugin</artifactId>
<configuration>
<skip>false</skip>
</configuration>
</plugin>
<plugin>
<groupId>biz.aQute.bnd</groupId>
<artifactId>bnd-maven-plugin</artifactId>
Expand Down
6 changes: 6 additions & 0 deletions exporter-sender-okhttp/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@

<build>
<plugins>
<plugin>
<artifactId>maven-remote-resources-plugin</artifactId>
<configuration>
<skip>false</skip>
</configuration>
</plugin>
<plugin>
<groupId>biz.aQute.bnd</groupId>
<artifactId>bnd-maven-plugin</artifactId>
Expand Down
6 changes: 6 additions & 0 deletions exporter/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@

<build>
<plugins>
<plugin>
<artifactId>maven-remote-resources-plugin</artifactId>
<configuration>
<skip>false</skip>
</configuration>
</plugin>
<plugin>
<groupId>biz.aQute.bnd</groupId>
<artifactId>bnd-maven-plugin</artifactId>
Expand Down
6 changes: 6 additions & 0 deletions features/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@
</resource>
</resources>
<plugins>
<plugin>
<artifactId>maven-remote-resources-plugin</artifactId>
<configuration>
<skip>false</skip>
</configuration>
</plugin>
<plugin>
<artifactId>maven-resources-plugin</artifactId>
<executions>
Expand Down
16 changes: 16 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,22 @@
</execution>
</executions>
</plugin>

<!-- org.apache:apache:21 sets maven-remote-resources-plugin in plugins, not pluginManagement
This results in execution in the parent project, and a side effect of an empty
DEPENDENCIES file in the assembly when packaged with the apache-release profile.
https://issues.apache.org/jira/browse/MPOM-218
This works around the problem by skipping at the parent level at the cost of having to
un-skip it at every deployed child.
-->
<plugin>
<artifactId>maven-remote-resources-plugin</artifactId>
<configuration>
<skip>true</skip>
</configuration>
</plugin>
</plugins>
</build>

Expand Down

0 comments on commit 4c57150

Please sign in to comment.