ci: cleans up docker scripts and adds ppc64le note #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppc64le isn't an alpine package, yet, as noted in openzipkin/zipkin#3443 This skips trying that and also merges in the same build-bin/docker/* and build-bin/README.md from docker-alpine Finally, this adds more comments in the Dockerfile about the java_version vs java_home variables. Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
commented
Dec 5, 2023
| @@ -12,6 +12,10 @@ fi | |||
| export DOCKER_RELEASE_REPOS=ghcr.io | |||
| export DOCKER_FILE=Dockerfile | |||
|
|
|||
| # Don't attempt ppc64le until there's a package for recent LTS versions. | |||
| # See https://github.com/openzipkin/zipkin/issues/3443 | |||
| export DOCKER_ARCHS="amd64 arm64 s390x" | |||
There was a problem hiding this comment.
this is how we constrain archs without changing the docker scripts directly.
codefromthecrypt
commented
Dec 5, 2023
| # When updating, also update the README | ||
| # * Use current version from https://pkgs.alpinelinux.org/packages?name=openjdk21, stripping | ||
| # the `-rX` at the end. | ||
| ARG java_version=21.0.1_p12 | ||
| ARG java_home=/usr/lib/jvm/java-21-openjdk |
There was a problem hiding this comment.
moved these together so it is easier to see the impact
Signed-off-by: Adrian Cole <[email protected]>
anuraaga
approved these changes
Dec 5, 2023
|
thanks for the look.. I will test deploy JDK 11, 17 and 21 with latest patches now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ppc64le isn't an alpine package, yet, as noted in
openzipkin/zipkin#3443
This skips trying that and also merges in the same build-bin/docker/* and build-bin/README.md from docker-alpine
Finally, this adds more comments in the Dockerfile about the java_version vs java_home variables.