Skip to content

Commit

Permalink
Fix subscription name format
Browse files Browse the repository at this point in the history
A feature added in the client now validates the subscription name format when dispatching messages as a side effect, even if that feature isn't enabled. Uses a correctly formatted subscription name in the test.
  • Loading branch information
shakuzen committed Nov 28, 2024
1 parent 86d8487 commit 0c1969d
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import com.google.api.gax.rpc.FixedTransportChannelProvider;
import com.google.api.gax.rpc.TransportChannel;
import com.google.api.gax.rpc.TransportChannelProvider;
import com.google.pubsub.v1.SubscriptionName;
import io.grpc.ManagedChannel;
import io.grpc.Server;
import io.grpc.inprocess.InProcessChannelBuilder;
Expand Down Expand Up @@ -76,7 +77,7 @@ class PubSubCollectorTest {
FlowControlSettings.newBuilder().setMaxOutstandingElementCount(1000L).build());

collector = new PubSubCollector.Builder()
.subscription("projects/test-project/topics/test-subscription")
.subscription(SubscriptionName.format("test-project", "test-subscription"))
.storage(store)
.encoding(Encoding.JSON)
.executorProvider(executorProvider)
Expand Down

0 comments on commit 0c1969d

Please sign in to comment.