Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make serviceName check null-safe #149

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Make serviceName check null-safe #149

merged 2 commits into from
Sep 16, 2019

Conversation

z-oo
Copy link
Contributor

@z-oo z-oo commented Sep 13, 2019

Span object stores localEndpoint.serviceName empty string as null so .isEmpty() throws NullPointerException.

@z-oo
Make serviceName check null-safe
48777fb 
Span object stores `localEndpoint.serviceName` empty string as null so `.isEmpty()` throws NullPointerException.
@z-oo
Copy link
Contributor Author

z-oo commented Sep 13, 2019

This should fix #148

devinsba
devinsba reviewed Sep 13, 2019
View reviewed changes
Copy link
Member

@devinsba devinsba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a test for this

@z-oo
Copy link
Contributor Author

z-oo commented Sep 13, 2019

@devinsba test added. PTAL.

@z-oo z-oo requested a review from devinsba September 14, 2019 21:19
codefromthecrypt
codefromthecrypt approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @z-oo and thanks @devinsba for the help reviewing

@codefromthecrypt codefromthecrypt merged commit c6dadd6 into openzipkin:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

@devinsba devinsba Awaiting requested review from devinsba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@z-oo @codefromthecrypt @devinsba