Skip to content

Commit

Permalink
Add service annotations (#31)
Browse files Browse the repository at this point in the history
  • Loading branch information
scbogdan authored Jan 2, 2025
1 parent 349f04a commit c9dfc50
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ You can then run `helm search repo zipkin` to see the charts.
| securityContext.runAsUser | int | `1000` | |
| service.port | int | `9411` | |
| service.type | string | `"ClusterIP"` | |
| service.annotations | object | `{}` | |
| serviceAccount.annotations | object | `{}` | |
| serviceAccount.create | bool | `true` | |
| serviceAccount.name | string | `""` | If not set and create is true, a name is generated using the fullname template |
Expand Down
4 changes: 4 additions & 0 deletions charts/zipkin/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ metadata:
namespace: {{ include "zipkin.namespace" . }}
labels:
{{- include "zipkin.labels" . | nindent 4 }}
{{- with .Values.service.annotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
type: {{ .Values.service.type }}
ports:
Expand Down
3 changes: 3 additions & 0 deletions charts/zipkin/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,9 @@
},
"type": {
"type": "string"
},
"annotations": {
"type": "object"
}
}
},
Expand Down
1 change: 1 addition & 0 deletions charts/zipkin/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ securityContext:
service:
type: ClusterIP
port: 9411
annotations: {}

serviceMonitor:
# Creates a ServiceMonitor to scrape /prometheus
Expand Down

0 comments on commit c9dfc50

Please sign in to comment.