-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add supports for zipkin-dependencies job as a k8s cronjob #11
base: master
Are you sure you want to change the base?
feature: add supports for zipkin-dependencies job as a k8s cronjob #11
Conversation
sorry I accidentally wasn't watching this repo. looking now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, the config approach is the same for mysql or cassandra, (prefixed variables associated to the storage type should be re-used for the dependency job)
one thing needed is how to test this here, as the job is something easy to get wrong by accident. I assume this is "out sourcing" the cron part to k8s itself, in this case, it should be changing the entrypoint also to prevent the container from using its cron. You can look at this
https://github.com/openzipkin/zipkin/tree/master/docker/examples#elasticsearch
Probably the best thing before starting this would be to add a better test, that generates a trace.. like this in a separate PR https://github.com/openzipkin/brave-example/blob/14a408d0bf2197bfc24e2d8935256e2508ad2d30/build-bin/docker-compose.base.yml
Then, this a test for dependencies could layer on that, and once the trace is readable, run the dependnecies job and see if the dependency endpoint has the "frontend" -> "backend" link
#13 will backfill a basic test. |
I think to help I'll try to get a test for elasticsearch config in the first place, then doing something like this will be easier to verify. I'll plug at this slowly unless you beat me to it! |
ok #17 sets up the baseline to test this #17 Here's the jist of things needed to land this reliably:
I'll wait on you to tell me how comfortable you feel with these steps, and forgive me not eyeballing some change I didn't think about. |
Feel free to suggest some changes
Regards